Skip to content

Update isDynamic api to align with is_symbolic API in upstream #3888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 18, 2022
Merged

Update isDynamic api to align with is_symbolic API in upstream #3888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
320c65a
updated isDynamic api
miladm Aug 15, 2022
2863bd8
added a torch pin to upstream PR for testing
miladm Aug 15, 2022
8b042a5
removed torch pin
miladm Aug 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions torch_xla/csrc/ops/dynamic_ir.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ int64_t SizeNode::getStaticValue() const {
return operand(0).node->shape(0).size(dim_);
}

bool SizeNode::isDynamic() const {
bool SizeNode::isSymbolic() const {
auto symbolic_vec = operand(0).node->shape(0).is_symbolic();
if (!symbolic_vec.has_value()) {
return true;
Expand All @@ -47,8 +47,8 @@ int64_t SizeAdd::getStaticValue() const {
->getStaticValue();
}

bool SizeAdd::isDynamic() const {
return DimCast(operand(0))->isDynamic() || DimCast(operand(1))->isDynamic();
bool SizeAdd::isSymbolic() const {
return DimCast(operand(0))->isSymbolic() || DimCast(operand(1))->isSymbolic();
}

std::string SizeAdd::ToString() const { return "SizeAdd"; }
Expand All @@ -72,8 +72,8 @@ int64_t SizeMul::getStaticValue() const {
->getStaticValue();
}

bool SizeMul::isDynamic() const {
return DimCast(operand(0))->isDynamic() || DimCast(operand(1))->isDynamic();
bool SizeMul::isSymbolic() const {
return DimCast(operand(0))->isSymbolic() || DimCast(operand(1))->isSymbolic();
}

std::string SizeMul::ToString() const { return "SizeMul"; }
Expand All @@ -100,8 +100,8 @@ int64_t SizeDiv::getStaticValue() const {
->getStaticValue();
}

bool SizeDiv::isDynamic() const {
return DimCast(operand(0))->isDynamic() || DimCast(operand(1))->isDynamic();
bool SizeDiv::isSymbolic() const {
return DimCast(operand(0))->isSymbolic() || DimCast(operand(1))->isSymbolic();
}

std::string SizeDiv::ToString() const { return "SizeDiv"; }
Expand Down
8 changes: 4 additions & 4 deletions torch_xla/csrc/ops/dynamic_ir.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ class SizeNode : public XlaNode, public torch::lazy::DimensionNode {
public:
SizeNode(torch::lazy::Value input, size_t dim);
int64_t getStaticValue() const override;
bool isDynamic() const override;
bool isSymbolic() const override;
std::string ToString() const override;
virtual XlaOpVector Lower(LoweringContext* loctx) const override;

Expand All @@ -51,7 +51,7 @@ class SizeAdd : public XlaNode, public torch::lazy::DimensionNode {
public:
SizeAdd(torch::lazy::Value a, torch::lazy::Value b);
int64_t getStaticValue() const override;
bool isDynamic() const override;
bool isSymbolic() const override;
std::string ToString() const override;
virtual XlaOpVector Lower(LoweringContext* loctx) const override;
};
Expand All @@ -60,7 +60,7 @@ class SizeMul : public XlaNode, public torch::lazy::DimensionNode {
public:
SizeMul(torch::lazy::Value a, torch::lazy::Value b);
int64_t getStaticValue() const override;
bool isDynamic() const override;
bool isSymbolic() const override;
std::string ToString() const override;
virtual XlaOpVector Lower(LoweringContext* loctx) const override;
};
Expand All @@ -69,7 +69,7 @@ class SizeDiv : public XlaNode, public torch::lazy::DimensionNode {
public:
SizeDiv(torch::lazy::Value a, torch::lazy::Value b);
int64_t getStaticValue() const override;
bool isDynamic() const override;
bool isSymbolic() const override;
std::string ToString() const override;
virtual XlaOpVector Lower(LoweringContext* loctx) const override;
};
Expand Down
2 changes: 1 addition & 1 deletion torch_xla/csrc/torch_util.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ void SymIntElements::SetSymIntNodeElements(c10::SymInt& size) {
->getStaticValue());
dynamic_dims_.push_back(
std::dynamic_pointer_cast<torch::lazy::DimensionNode>(size_node)
->isDynamic());
->isSymbolic());
} else {
auto size_node = torch::lazy::MakeNode<Constant>(std::move(
XlaHelpers::ScalarLiteral(size.expect_int(), xla::PrimitiveType::S32)));
Expand Down