[LTC] Override LazyGraphExecutor::RunPostOrder() #4315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanwaketan
force-pushed
the
alanwaketan/lazy_graph_5
branch
from
098eab7 to
5718904
Compare
wonjoo-wj
approved these changes
Dec 12, 2022
JackCaoG
approved these changes
Dec 12, 2022
|
Thanks Wonjoo and Jack. |
alanwaketan
force-pushed
the
alanwaketan/lazy_graph_5
branch
from
5718904 to
adab74e
Compare
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Dec 13, 2022
Summary: This patch makes LazyGraphExecutor::RunPostOrder() virtual such that XLA can reuse it. It's related to pytorch/xla#4315. Test Plan: CI. Pull Request resolved: #90680 Approved by: https://github.com/antoniojkim, https://github.com/JackCaoG
This reverts commit adab74e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This patch overrides LazyGraphExecutor::RunPostOrder() and adds a few comments on why some methods are different from the upstream.
This depends on pytorch/pytorch#90680.
Test Plan:
CI