Re-enable more dynamic shape tests #4558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanbasten23
commented
Feb 3, 2023
| // https://github.com/pytorch/pytorch/blob/master/torch/fx/experimental/symbolic_shapes.py#L403 | ||
| if (op == at::aten::eq || op == at::aten::ne || op == at::aten::ge || | ||
| op == at::aten::lt) { | ||
| if (op == c10::Symbol::fromQualString("aten::size_eq") || |
There was a problem hiding this comment.
@alanwaketan I tried to use switch but c10::Symbol::fromQualString("aten::size_eq") are not constant so the build would fail.
There was a problem hiding this comment.
Right, it wasn't like the enum before.
alanwaketan
approved these changes
Feb 3, 2023
| // https://github.com/pytorch/pytorch/blob/master/torch/fx/experimental/symbolic_shapes.py#L403 | ||
| if (op == at::aten::eq || op == at::aten::ne || op == at::aten::ge || | ||
| op == at::aten::lt) { | ||
| if (op == c10::Symbol::fromQualString("aten::size_eq") || |
There was a problem hiding this comment.
Right, it wasn't like the enum before.
|
Please make sure the CIs are passing before merging. |
vanbasten23
force-pushed
the
functionalization
branch
from
974c3a9 to
caccc62
Compare
vanbasten23
force-pushed
the
fixMoreTests2
branch
from
41aa6d2 to
5ae45eb
Compare
wonjoo-wj
pushed a commit
that referenced
this pull request
Feb 7, 2023
* fix size node ne op kind to be size_ne * reenable test_nonzero_cast * fix linter * disable new failing test after rebase temporarily. * fix linter
alanwaketan
pushed a commit
that referenced
this pull request
Feb 8, 2023
* fix size node ne op kind to be size_ne * reenable test_nonzero_cast * fix linter * disable new failing test after rebase temporarily. * fix linter
alanwaketan
pushed a commit
that referenced
this pull request
Feb 15, 2023
* fix size node ne op kind to be size_ne * reenable test_nonzero_cast * fix linter * disable new failing test after rebase temporarily. * fix linter
alanwaketan
pushed a commit
that referenced
this pull request
Feb 21, 2023
* fix size node ne op kind to be size_ne * reenable test_nonzero_cast * fix linter * disable new failing test after rebase temporarily. * fix linter
vanbasten23
added a commit
that referenced
this pull request
Feb 23, 2023
* fix size node ne op kind to be size_ne * reenable test_nonzero_cast * fix linter * disable new failing test after rebase temporarily. * fix linter
vanbasten23
added a commit
that referenced
this pull request
Feb 23, 2023
* fix size node ne op kind to be size_ne * reenable test_nonzero_cast * fix linter * disable new failing test after rebase temporarily. * fix linter
alanwaketan
pushed a commit
that referenced
this pull request
Feb 24, 2023
* fix size node ne op kind to be size_ne * reenable test_nonzero_cast * fix linter * disable new failing test after rebase temporarily. * fix linter
vanbasten23
added a commit
that referenced
this pull request
Feb 24, 2023
* Disable failing XLA tests * Re-enable dynamo tests (#4454) * Turn on keep going * Re-enable more dynamic shape tests (#4558) * fix size node ne op kind to be size_ne * reenable test_nonzero_cast * fix linter * disable new failing test after rebase temporarily. * fix linter * [Functionalization] Fix ScatterReduce (#4576) Summary: ScatterReduce::reduce_ uses a unsafe type c10::string_view to store the string. Replace it with std::string and re-enable all previous failing tests. Test Plan: TPU_LIBRARY_PATH=/home/ptxla/.local/lib/python3.8/site-packages/libtpu/libtpu.so PJRT_DEVICE=CPU test/cpp/build/test_ptxla --gtest_filter=AtenXlaTensorTest.TestScatterReduce* * Revert "Turn on keep going" This reverts commit 224bdf3. * Turn on keep going * Revert "Turn on keep going" This reverts commit 224bdf3. * Turn on keep going * Revert "Turn on keep going" This reverts commit 224bdf3. * code compiles * wrote new test TestDynamicShapes.test_sizeMod and it succeeds. * the first view_copy_symint test test_view_copy_symint_with_dyn_input_shape passed * added two more tests * run linter * added a new failing test with negative shape * fix all tests * clean up * clean up * fix a small test failure. * fix pr comments * updated the tests for dynamic input and static input shape * not support dynamic input and static input shape. * fix linter * fix pr comments * fix build error * resolve a rebase conflict * run linter * add one more test * add one more test and it passes. * fix linter * remove experiemental test. --------- Co-authored-by: Wonjoo Lee <wonjoo@google.com> Co-authored-by: Jiewen Tan <jwtan@google.com>
vanbasten23
added a commit
that referenced
this pull request
Feb 24, 2023
* fix size node ne op kind to be size_ne * reenable test_nonzero_cast * fix linter * disable new failing test after rebase temporarily. * fix linter
vanbasten23
added a commit
that referenced
this pull request
Feb 24, 2023
* Disable failing XLA tests * Re-enable dynamo tests (#4454) * Turn on keep going * Re-enable more dynamic shape tests (#4558) * fix size node ne op kind to be size_ne * reenable test_nonzero_cast * fix linter * disable new failing test after rebase temporarily. * fix linter * [Functionalization] Fix ScatterReduce (#4576) Summary: ScatterReduce::reduce_ uses a unsafe type c10::string_view to store the string. Replace it with std::string and re-enable all previous failing tests. Test Plan: TPU_LIBRARY_PATH=/home/ptxla/.local/lib/python3.8/site-packages/libtpu/libtpu.so PJRT_DEVICE=CPU test/cpp/build/test_ptxla --gtest_filter=AtenXlaTensorTest.TestScatterReduce* * Revert "Turn on keep going" This reverts commit 224bdf3. * Turn on keep going * Revert "Turn on keep going" This reverts commit 224bdf3. * Turn on keep going * Revert "Turn on keep going" This reverts commit 224bdf3. * code compiles * wrote new test TestDynamicShapes.test_sizeMod and it succeeds. * the first view_copy_symint test test_view_copy_symint_with_dyn_input_shape passed * added two more tests * run linter * added a new failing test with negative shape * fix all tests * clean up * clean up * fix a small test failure. * fix pr comments * updated the tests for dynamic input and static input shape * not support dynamic input and static input shape. * fix linter * fix pr comments * fix build error * resolve a rebase conflict * run linter * add one more test * add one more test and it passes. * fix linter * remove experiemental test. --------- Co-authored-by: Wonjoo Lee <wonjoo@google.com> Co-authored-by: Jiewen Tan <jwtan@google.com>
alanwaketan
pushed a commit
that referenced
this pull request
Mar 1, 2023
* fix size node ne op kind to be size_ne * reenable test_nonzero_cast * fix linter * disable new failing test after rebase temporarily. * fix linter
vanbasten23
added a commit
that referenced
this pull request
Mar 7, 2023
Support dynamism on "transpose" operation. (#4606) * added failing test_t_copy test * made transpose work * disable the backward pass. * fix linter Add dynamic shape test for unsqueeze_copy (#4608) * added failing test * test correctness. Support dynamism on view_copy_symint (#4629) * Disable failing XLA tests * Re-enable dynamo tests (#4454) * Turn on keep going * Re-enable more dynamic shape tests (#4558) * fix size node ne op kind to be size_ne * reenable test_nonzero_cast * fix linter * disable new failing test after rebase temporarily. * fix linter * [Functionalization] Fix ScatterReduce (#4576) Summary: ScatterReduce::reduce_ uses a unsafe type c10::string_view to store the string. Replace it with std::string and re-enable all previous failing tests. Test Plan: TPU_LIBRARY_PATH=/home/ptxla/.local/lib/python3.8/site-packages/libtpu/libtpu.so PJRT_DEVICE=CPU test/cpp/build/test_ptxla --gtest_filter=AtenXlaTensorTest.TestScatterReduce* * Revert "Turn on keep going" This reverts commit 224bdf3. * Turn on keep going * Revert "Turn on keep going" This reverts commit 224bdf3. * Turn on keep going * Revert "Turn on keep going" This reverts commit 224bdf3. * code compiles * wrote new test TestDynamicShapes.test_sizeMod and it succeeds. * the first view_copy_symint test test_view_copy_symint_with_dyn_input_shape passed * added two more tests * run linter * added a new failing test with negative shape * fix all tests * clean up * clean up * fix a small test failure. * fix pr comments * updated the tests for dynamic input and static input shape * not support dynamic input and static input shape. * fix linter * fix pr comments * fix build error * resolve a rebase conflict * run linter * add one more test * add one more test and it passes. * fix linter * remove experiemental test. --------- Co-authored-by: Wonjoo Lee <wonjoo@google.com> Co-authored-by: Jiewen Tan <jwtan@google.com> fix a merge error fix other merge error during rebase.
vanbasten23
added a commit
that referenced
this pull request
Mar 8, 2023
Support dynamism on "transpose" operation. (#4606) * added failing test_t_copy test * made transpose work * disable the backward pass. * fix linter Add dynamic shape test for unsqueeze_copy (#4608) * added failing test * test correctness. Support dynamism on view_copy_symint (#4629) * Disable failing XLA tests * Re-enable dynamo tests (#4454) * Turn on keep going * Re-enable more dynamic shape tests (#4558) * fix size node ne op kind to be size_ne * reenable test_nonzero_cast * fix linter * disable new failing test after rebase temporarily. * fix linter * [Functionalization] Fix ScatterReduce (#4576) Summary: ScatterReduce::reduce_ uses a unsafe type c10::string_view to store the string. Replace it with std::string and re-enable all previous failing tests. Test Plan: TPU_LIBRARY_PATH=/home/ptxla/.local/lib/python3.8/site-packages/libtpu/libtpu.so PJRT_DEVICE=CPU test/cpp/build/test_ptxla --gtest_filter=AtenXlaTensorTest.TestScatterReduce* * Revert "Turn on keep going" This reverts commit 224bdf3. * Turn on keep going * Revert "Turn on keep going" This reverts commit 224bdf3. * Turn on keep going * Revert "Turn on keep going" This reverts commit 224bdf3. * code compiles * wrote new test TestDynamicShapes.test_sizeMod and it succeeds. * the first view_copy_symint test test_view_copy_symint_with_dyn_input_shape passed * added two more tests * run linter * added a new failing test with negative shape * fix all tests * clean up * clean up * fix a small test failure. * fix pr comments * updated the tests for dynamic input and static input shape * not support dynamic input and static input shape. * fix linter * fix pr comments * fix build error * resolve a rebase conflict * run linter * add one more test * add one more test and it passes. * fix linter * remove experiemental test. --------- Co-authored-by: Wonjoo Lee <wonjoo@google.com> Co-authored-by: Jiewen Tan <jwtan@google.com> fix a merge error fix other merge error during rebase.
vanbasten23
added a commit
that referenced
this pull request
Mar 9, 2023
* Support dynamism on "transpose", unsqueeze_copy, and view_copy_symint. Support dynamism on "transpose" operation. (#4606) * added failing test_t_copy test * made transpose work * disable the backward pass. * fix linter Add dynamic shape test for unsqueeze_copy (#4608) * added failing test * test correctness. Support dynamism on view_copy_symint (#4629) * Disable failing XLA tests * Re-enable dynamo tests (#4454) * Turn on keep going * Re-enable more dynamic shape tests (#4558) * fix size node ne op kind to be size_ne * reenable test_nonzero_cast * fix linter * disable new failing test after rebase temporarily. * fix linter * [Functionalization] Fix ScatterReduce (#4576) Summary: ScatterReduce::reduce_ uses a unsafe type c10::string_view to store the string. Replace it with std::string and re-enable all previous failing tests. Test Plan: TPU_LIBRARY_PATH=/home/ptxla/.local/lib/python3.8/site-packages/libtpu/libtpu.so PJRT_DEVICE=CPU test/cpp/build/test_ptxla --gtest_filter=AtenXlaTensorTest.TestScatterReduce* * Revert "Turn on keep going" This reverts commit 224bdf3. * Turn on keep going * Revert "Turn on keep going" This reverts commit 224bdf3. * Turn on keep going * Revert "Turn on keep going" This reverts commit 224bdf3. * code compiles * wrote new test TestDynamicShapes.test_sizeMod and it succeeds. * the first view_copy_symint test test_view_copy_symint_with_dyn_input_shape passed * added two more tests * run linter * added a new failing test with negative shape * fix all tests * clean up * clean up * fix a small test failure. * fix pr comments * updated the tests for dynamic input and static input shape * not support dynamic input and static input shape. * fix linter * fix pr comments * fix build error * resolve a rebase conflict * run linter * add one more test * add one more test and it passes. * fix linter * remove experiemental test. --------- Co-authored-by: Wonjoo Lee <wonjoo@google.com> Co-authored-by: Jiewen Tan <jwtan@google.com> fix a merge error fix other merge error during rebase. * Track type of SymNode for XLASymNodeImpl::mod (#4732)
mateuszlewko
pushed a commit
that referenced
this pull request
Mar 15, 2023
* Support dynamism on "transpose", unsqueeze_copy, and view_copy_symint. Support dynamism on "transpose" operation. (#4606) * added failing test_t_copy test * made transpose work * disable the backward pass. * fix linter Add dynamic shape test for unsqueeze_copy (#4608) * added failing test * test correctness. Support dynamism on view_copy_symint (#4629) * Disable failing XLA tests * Re-enable dynamo tests (#4454) * Turn on keep going * Re-enable more dynamic shape tests (#4558) * fix size node ne op kind to be size_ne * reenable test_nonzero_cast * fix linter * disable new failing test after rebase temporarily. * fix linter * [Functionalization] Fix ScatterReduce (#4576) Summary: ScatterReduce::reduce_ uses a unsafe type c10::string_view to store the string. Replace it with std::string and re-enable all previous failing tests. Test Plan: TPU_LIBRARY_PATH=/home/ptxla/.local/lib/python3.8/site-packages/libtpu/libtpu.so PJRT_DEVICE=CPU test/cpp/build/test_ptxla --gtest_filter=AtenXlaTensorTest.TestScatterReduce* * Revert "Turn on keep going" This reverts commit 224bdf3. * Turn on keep going * Revert "Turn on keep going" This reverts commit 224bdf3. * Turn on keep going * Revert "Turn on keep going" This reverts commit 224bdf3. * code compiles * wrote new test TestDynamicShapes.test_sizeMod and it succeeds. * the first view_copy_symint test test_view_copy_symint_with_dyn_input_shape passed * added two more tests * run linter * added a new failing test with negative shape * fix all tests * clean up * clean up * fix a small test failure. * fix pr comments * updated the tests for dynamic input and static input shape * not support dynamic input and static input shape. * fix linter * fix pr comments * fix build error * resolve a rebase conflict * run linter * add one more test * add one more test and it passes. * fix linter * remove experiemental test. --------- Co-authored-by: Wonjoo Lee <wonjoo@google.com> Co-authored-by: Jiewen Tan <jwtan@google.com> fix a merge error fix other merge error during rebase. * Track type of SymNode for XLASymNodeImpl::mod (#4732)
ManfeiBai
pushed a commit
to ManfeiBai/PyTorchXLA
that referenced
this pull request
Mar 29, 2023
* Support dynamism on "transpose", unsqueeze_copy, and view_copy_symint. Support dynamism on "transpose" operation. (pytorch#4606) * added failing test_t_copy test * made transpose work * disable the backward pass. * fix linter Add dynamic shape test for unsqueeze_copy (pytorch#4608) * added failing test * test correctness. Support dynamism on view_copy_symint (pytorch#4629) * Disable failing XLA tests * Re-enable dynamo tests (pytorch#4454) * Turn on keep going * Re-enable more dynamic shape tests (pytorch#4558) * fix size node ne op kind to be size_ne * reenable test_nonzero_cast * fix linter * disable new failing test after rebase temporarily. * fix linter * [Functionalization] Fix ScatterReduce (pytorch#4576) Summary: ScatterReduce::reduce_ uses a unsafe type c10::string_view to store the string. Replace it with std::string and re-enable all previous failing tests. Test Plan: TPU_LIBRARY_PATH=/home/ptxla/.local/lib/python3.8/site-packages/libtpu/libtpu.so PJRT_DEVICE=CPU test/cpp/build/test_ptxla --gtest_filter=AtenXlaTensorTest.TestScatterReduce* * Revert "Turn on keep going" This reverts commit 224bdf3. * Turn on keep going * Revert "Turn on keep going" This reverts commit 224bdf3. * Turn on keep going * Revert "Turn on keep going" This reverts commit 224bdf3. * code compiles * wrote new test TestDynamicShapes.test_sizeMod and it succeeds. * the first view_copy_symint test test_view_copy_symint_with_dyn_input_shape passed * added two more tests * run linter * added a new failing test with negative shape * fix all tests * clean up * clean up * fix a small test failure. * fix pr comments * updated the tests for dynamic input and static input shape * not support dynamic input and static input shape. * fix linter * fix pr comments * fix build error * resolve a rebase conflict * run linter * add one more test * add one more test and it passes. * fix linter * remove experiemental test. --------- Co-authored-by: Wonjoo Lee <wonjoo@google.com> Co-authored-by: Jiewen Tan <jwtan@google.com> fix a merge error fix other merge error during rebase. * Track type of SymNode for XLASymNodeImpl::mod (pytorch#4732)
ManfeiBai
pushed a commit
to ManfeiBai/PyTorchXLA
that referenced
this pull request
Mar 29, 2023
* Support dynamism on "transpose", unsqueeze_copy, and view_copy_symint. Support dynamism on "transpose" operation. (pytorch#4606) * added failing test_t_copy test * made transpose work * disable the backward pass. * fix linter Add dynamic shape test for unsqueeze_copy (pytorch#4608) * added failing test * test correctness. Support dynamism on view_copy_symint (pytorch#4629) * Disable failing XLA tests * Re-enable dynamo tests (pytorch#4454) * Turn on keep going * Re-enable more dynamic shape tests (pytorch#4558) * fix size node ne op kind to be size_ne * reenable test_nonzero_cast * fix linter * disable new failing test after rebase temporarily. * fix linter * [Functionalization] Fix ScatterReduce (pytorch#4576) Summary: ScatterReduce::reduce_ uses a unsafe type c10::string_view to store the string. Replace it with std::string and re-enable all previous failing tests. Test Plan: TPU_LIBRARY_PATH=/home/ptxla/.local/lib/python3.8/site-packages/libtpu/libtpu.so PJRT_DEVICE=CPU test/cpp/build/test_ptxla --gtest_filter=AtenXlaTensorTest.TestScatterReduce* * Revert "Turn on keep going" This reverts commit 224bdf3. * Turn on keep going * Revert "Turn on keep going" This reverts commit 224bdf3. * Turn on keep going * Revert "Turn on keep going" This reverts commit 224bdf3. * code compiles * wrote new test TestDynamicShapes.test_sizeMod and it succeeds. * the first view_copy_symint test test_view_copy_symint_with_dyn_input_shape passed * added two more tests * run linter * added a new failing test with negative shape * fix all tests * clean up * clean up * fix a small test failure. * fix pr comments * updated the tests for dynamic input and static input shape * not support dynamic input and static input shape. * fix linter * fix pr comments * fix build error * resolve a rebase conflict * run linter * add one more test * add one more test and it passes. * fix linter * remove experiemental test. --------- Co-authored-by: Wonjoo Lee <wonjoo@google.com> Co-authored-by: Jiewen Tan <jwtan@google.com> fix a merge error fix other merge error during rebase. * Track type of SymNode for XLASymNodeImpl::mod (pytorch#4732)
vanbasten23
added a commit
that referenced
this pull request
Apr 29, 2023
* fix size node ne op kind to be size_ne * reenable test_nonzero_cast * fix linter * disable new failing test after rebase temporarily. * fix linter
vanbasten23
added a commit
that referenced
this pull request
Apr 29, 2023
* fix size node ne op kind to be size_ne * reenable test_nonzero_cast * fix linter * disable new failing test after rebase temporarily. * fix linter
vanbasten23
added a commit
that referenced
this pull request
Apr 29, 2023
* Disable failing XLA tests * Re-enable dynamo tests (#4454) * Turn on keep going * Re-enable more dynamic shape tests (#4558) * fix size node ne op kind to be size_ne * reenable test_nonzero_cast * fix linter * disable new failing test after rebase temporarily. * fix linter * [Functionalization] Fix ScatterReduce (#4576) Summary: ScatterReduce::reduce_ uses a unsafe type c10::string_view to store the string. Replace it with std::string and re-enable all previous failing tests. Test Plan: TPU_LIBRARY_PATH=/home/ptxla/.local/lib/python3.8/site-packages/libtpu/libtpu.so PJRT_DEVICE=CPU test/cpp/build/test_ptxla --gtest_filter=AtenXlaTensorTest.TestScatterReduce* * Revert "Turn on keep going" This reverts commit 224bdf3. * Turn on keep going * Revert "Turn on keep going" This reverts commit 224bdf3. * Turn on keep going * Revert "Turn on keep going" This reverts commit 224bdf3. * code compiles * wrote new test TestDynamicShapes.test_sizeMod and it succeeds. * the first view_copy_symint test test_view_copy_symint_with_dyn_input_shape passed * added two more tests * run linter * added a new failing test with negative shape * fix all tests * clean up * clean up * fix a small test failure. * fix pr comments * updated the tests for dynamic input and static input shape * not support dynamic input and static input shape. * fix linter * fix pr comments * fix build error * resolve a rebase conflict * run linter * add one more test * add one more test and it passes. * fix linter * remove experiemental test. --------- Co-authored-by: Wonjoo Lee <wonjoo@google.com> Co-authored-by: Jiewen Tan <jwtan@google.com>
vanbasten23
added a commit
that referenced
this pull request
May 12, 2023
* fix size node ne op kind to be size_ne * reenable test_nonzero_cast * fix linter * disable new failing test after rebase temporarily. * fix linter
vanbasten23
added a commit
that referenced
this pull request
May 12, 2023
* fix size node ne op kind to be size_ne * reenable test_nonzero_cast * fix linter * disable new failing test after rebase temporarily. * fix linter
vanbasten23
added a commit
that referenced
this pull request
May 12, 2023
* Disable failing XLA tests * Re-enable dynamo tests (#4454) * Turn on keep going * Re-enable more dynamic shape tests (#4558) * fix size node ne op kind to be size_ne * reenable test_nonzero_cast * fix linter * disable new failing test after rebase temporarily. * fix linter * [Functionalization] Fix ScatterReduce (#4576) Summary: ScatterReduce::reduce_ uses a unsafe type c10::string_view to store the string. Replace it with std::string and re-enable all previous failing tests. Test Plan: TPU_LIBRARY_PATH=/home/ptxla/.local/lib/python3.8/site-packages/libtpu/libtpu.so PJRT_DEVICE=CPU test/cpp/build/test_ptxla --gtest_filter=AtenXlaTensorTest.TestScatterReduce* * Revert "Turn on keep going" This reverts commit 224bdf3. * Turn on keep going * Revert "Turn on keep going" This reverts commit 224bdf3. * Turn on keep going * Revert "Turn on keep going" This reverts commit 224bdf3. * code compiles * wrote new test TestDynamicShapes.test_sizeMod and it succeeds. * the first view_copy_symint test test_view_copy_symint_with_dyn_input_shape passed * added two more tests * run linter * added a new failing test with negative shape * fix all tests * clean up * clean up * fix a small test failure. * fix pr comments * updated the tests for dynamic input and static input shape * not support dynamic input and static input shape. * fix linter * fix pr comments * fix build error * resolve a rebase conflict * run linter * add one more test * add one more test and it passes. * fix linter * remove experiemental test. --------- Co-authored-by: Wonjoo Lee <wonjoo@google.com> Co-authored-by: Jiewen Tan <jwtan@google.com>
vanbasten23
added a commit
that referenced
this pull request
Jun 21, 2023
* Disable failing XLA tests * Re-enable dynamo tests (#4454) * Turn on keep going * Re-enable more dynamic shape tests (#4558) * fix size node ne op kind to be size_ne * reenable test_nonzero_cast * fix linter * disable new failing test after rebase temporarily. * fix linter * [Functionalization] Fix ScatterReduce (#4576) Summary: ScatterReduce::reduce_ uses a unsafe type c10::string_view to store the string. Replace it with std::string and re-enable all previous failing tests. Test Plan: TPU_LIBRARY_PATH=/home/ptxla/.local/lib/python3.8/site-packages/libtpu/libtpu.so PJRT_DEVICE=CPU test/cpp/build/test_ptxla --gtest_filter=AtenXlaTensorTest.TestScatterReduce* * Revert "Turn on keep going" This reverts commit 224bdf3. * Turn on keep going * Revert "Turn on keep going" This reverts commit 224bdf3. * Turn on keep going * Revert "Turn on keep going" This reverts commit 224bdf3. * code compiles * wrote new test TestDynamicShapes.test_sizeMod and it succeeds. * the first view_copy_symint test test_view_copy_symint_with_dyn_input_shape passed * added two more tests * run linter * added a new failing test with negative shape * fix all tests * clean up * clean up * fix a small test failure. * fix pr comments * updated the tests for dynamic input and static input shape * not support dynamic input and static input shape. * fix linter * fix pr comments * fix build error * resolve a rebase conflict * run linter * add one more test * add one more test and it passes. * fix linter * remove experiemental test. --------- Co-authored-by: Wonjoo Lee <wonjoo@google.com> Co-authored-by: Jiewen Tan <jwtan@google.com>
vanbasten23
added a commit
that referenced
this pull request
Jun 24, 2023
* Disable failing XLA tests * Re-enable dynamo tests (#4454) * Turn on keep going * Re-enable more dynamic shape tests (#4558) * fix size node ne op kind to be size_ne * reenable test_nonzero_cast * fix linter * disable new failing test after rebase temporarily. * fix linter * [Functionalization] Fix ScatterReduce (#4576) Summary: ScatterReduce::reduce_ uses a unsafe type c10::string_view to store the string. Replace it with std::string and re-enable all previous failing tests. Test Plan: TPU_LIBRARY_PATH=/home/ptxla/.local/lib/python3.8/site-packages/libtpu/libtpu.so PJRT_DEVICE=CPU test/cpp/build/test_ptxla --gtest_filter=AtenXlaTensorTest.TestScatterReduce* * Revert "Turn on keep going" This reverts commit 224bdf3. * Turn on keep going * Revert "Turn on keep going" This reverts commit 224bdf3. * Turn on keep going * Revert "Turn on keep going" This reverts commit 224bdf3. * code compiles * wrote new test TestDynamicShapes.test_sizeMod and it succeeds. * the first view_copy_symint test test_view_copy_symint_with_dyn_input_shape passed * added two more tests * run linter * added a new failing test with negative shape * fix all tests * clean up * clean up * fix a small test failure. * fix pr comments * updated the tests for dynamic input and static input shape * not support dynamic input and static input shape. * fix linter * fix pr comments * fix build error * resolve a rebase conflict * run linter * add one more test * add one more test and it passes. * fix linter * remove experiemental test. --------- Co-authored-by: Wonjoo Lee <wonjoo@google.com> Co-authored-by: Jiewen Tan <jwtan@google.com>
vanbasten23
added a commit
that referenced
this pull request
Jun 27, 2023
* Disable failing XLA tests * Re-enable dynamo tests (#4454) * Turn on keep going * Re-enable more dynamic shape tests (#4558) * fix size node ne op kind to be size_ne * reenable test_nonzero_cast * fix linter * disable new failing test after rebase temporarily. * fix linter * [Functionalization] Fix ScatterReduce (#4576) Summary: ScatterReduce::reduce_ uses a unsafe type c10::string_view to store the string. Replace it with std::string and re-enable all previous failing tests. Test Plan: TPU_LIBRARY_PATH=/home/ptxla/.local/lib/python3.8/site-packages/libtpu/libtpu.so PJRT_DEVICE=CPU test/cpp/build/test_ptxla --gtest_filter=AtenXlaTensorTest.TestScatterReduce* * Revert "Turn on keep going" This reverts commit 224bdf3. * Turn on keep going * Revert "Turn on keep going" This reverts commit 224bdf3. * Turn on keep going * Revert "Turn on keep going" This reverts commit 224bdf3. * code compiles * wrote new test TestDynamicShapes.test_sizeMod and it succeeds. * the first view_copy_symint test test_view_copy_symint_with_dyn_input_shape passed * added two more tests * run linter * added a new failing test with negative shape * fix all tests * clean up * clean up * fix a small test failure. * fix pr comments * updated the tests for dynamic input and static input shape * not support dynamic input and static input shape. * fix linter * fix pr comments * fix build error * resolve a rebase conflict * run linter * add one more test * add one more test and it passes. * fix linter * remove experiemental test. --------- Co-authored-by: Wonjoo Lee <wonjoo@google.com> Co-authored-by: Jiewen Tan <jwtan@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr unifies all size_nodes to have op kind to be
size_opand re-enables the following test: