Add tesor debugging util API #5204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can also add a test on Monday, context is I am debugging a SPMD issue and I can't figure out why XLAData is a placeholder when it shouldn't, so I created this API |
|
@wonjoolee95 @alanwaketan This should be ready to review now. |
wonjoo-wj
approved these changes
Jun 20, 2023
ManfeiBai
pushed a commit
that referenced
this pull request
Jun 22, 2023
* Add tesor debugging util API * Add test of _get_xla_tensor_debug_info * fix typo * Disable the test for eager debug mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think having an internal API to dump XLATensor info is useful in debugging, it can dump something similar to
I didn't include view since I assume view will not be there after we clean up the functionization pass.