Skip to content

Not creating a coordinator service for the single processing job. #6023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 8, 2023
Merged

Not creating a coordinator service for the single processing job. #6023

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9255bec
Not creating the coordinator servie for single process.
vanbasten23 Dec 4, 2023
2c6c93b
fix comments
vanbasten23 Dec 6, 2023
9f8c2a8
revert a unwanted change
vanbasten23 Dec 6, 2023
8b0f9f5
fix linter
vanbasten23 Dec 7, 2023
a5ec7e8
fix one last comment
vanbasten23 Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions torch_xla/csrc/runtime/pjrt_computation_client.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,16 +177,16 @@ PjRtComputationClient::PjRtComputationClient() {
std::string port = runtime::sys_util::GetEnvString(
"XLA_COORDINATOR_PORT", XlaCoordinator::kDefaultCoordinatorPort);

// Use the XlaCoordinator as the distributed key-value store.
coordinator_ = std::make_unique<XlaCoordinator>(
global_process_rank, global_world_size, master_addr, port);
std::shared_ptr<xla::DistributedRuntimeClient> distributed_client =
coordinator_->GetClient();
auto allowed_devices =
std::make_optional<std::set<int>>(std::set{local_process_rank});
xla::PjRtClient::KeyValueGetCallback kv_get = nullptr;
xla::PjRtClient::KeyValuePutCallback kv_put = nullptr;
if (distributed_client != nullptr) {
auto allowed_devices =
std::make_optional<std::set<int>>(std::set{local_process_rank});
if (global_world_size > 1) {
// Use the XlaCoordinator as the distributed key-value store.
coordinator_ = std::make_unique<XlaCoordinator>(
global_process_rank, global_world_size, master_addr, port);
std::shared_ptr<xla::DistributedRuntimeClient> distributed_client =
coordinator_->GetClient();
std::string key_prefix = "gpu:";
kv_get = [distributed_client, key_prefix](
std::string_view k,
Expand Down