Revert "Fix model initialization. (#6076)" #6134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frgossen
requested review from
JackCaoG,
vanbasten23,
ysiraichi and
zpcore
and removed request for
JackCaoG
|
Sorry I didn't catch up with recent PRs. Do we already support automatically match dynamo backend |
|
We should support openxla_eval + eval, openxla + eval, and openxla + train |
zpcore
approved these changes
Dec 13, 2023
frgossen
force-pushed
the
frg-revert-6076
branch
from
c67100e to
6e61d8d
Compare
This reverts commit 7786d5d. `python benchmarks/experiment_runner.py --dynamo=openxla --dynamo=openxla_eval --dynamo=inductor --xla=PJRT --xla=None --test=eval --test=train --suite-name=torchbench --accelerator=cuda --filter=^alexnet$ --no-resume` fails for openxla benchmarks.
frgossen
force-pushed
the
frg-revert-6076
branch
from
6e61d8d to
833ec06
Compare
golechwierowicz
added a commit
that referenced
this pull request
Dec 13, 2023
I discovered some models from the suite do not have the precision set so instead of failing the script we just log the case, and use the default precision, as no additional machinery should run for the Inductor anyway. Additionally I wrapped the exceptions with the ValueError so the logging message will not pollute with info about str not inheriting from Exception class. ecg@, note that needs to be hooked "somewhere". Not sure where, as there was a revert in #6134.
golechwierowicz
added a commit
that referenced
this pull request
Dec 13, 2023
I discovered some models from the suite do not have the default precision set so instead of failing the script we just log the case, and do nothing, as no additional machinery should run for the Inductor anyway. Additionally I wrapped the exceptions with the ValueError so the logging message will not pollute with info about str not inheriting from Exception class. @cota , note that needs to be hooked "somewhere". Not sure where, as there was a revert in #6134, but in general it can be done prior to moving the model to the device safely.
chunnienc
pushed a commit
to chunnienc/xla
that referenced
this pull request
Dec 14, 2023
chunnienc
pushed a commit
to chunnienc/xla
that referenced
this pull request
Dec 14, 2023
I discovered some models from the suite do not have the default precision set so instead of failing the script we just log the case, and do nothing, as no additional machinery should run for the Inductor anyway. Additionally I wrapped the exceptions with the ValueError so the logging message will not pollute with info about str not inheriting from Exception class. @cota , note that needs to be hooked "somewhere". Not sure where, as there was a revert in pytorch#6134, but in general it can be done prior to moving the model to the device safely.
golechwierowicz
pushed a commit
that referenced
this pull request
Jan 12, 2024
golechwierowicz
added a commit
that referenced
this pull request
Jan 12, 2024
I discovered some models from the suite do not have the default precision set so instead of failing the script we just log the case, and do nothing, as no additional machinery should run for the Inductor anyway. Additionally I wrapped the exceptions with the ValueError so the logging message will not pollute with info about str not inheriting from Exception class. @cota , note that needs to be hooked "somewhere". Not sure where, as there was a revert in #6134, but in general it can be done prior to moving the model to the device safely.
bhavya01
pushed a commit
that referenced
this pull request
Apr 22, 2024
bhavya01
pushed a commit
that referenced
this pull request
Apr 22, 2024
I discovered some models from the suite do not have the default precision set so instead of failing the script we just log the case, and do nothing, as no additional machinery should run for the Inductor anyway. Additionally I wrapped the exceptions with the ValueError so the logging message will not pollute with info about str not inheriting from Exception class. @cota , note that needs to be hooked "somewhere". Not sure where, as there was a revert in #6134, but in general it can be done prior to moving the model to the device safely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 7786d5d.
python benchmarks/experiment_runner.py --dynamo=openxla --dynamo=openxla_eval --dynamo=inductor --xla=PJRT --xla=None --test=eval --test=train --suite-name=torchbench --accelerator=cuda --filter=^alexnet$ --no-resumefails for openxla benchmarks.