-
Couldn't load subscription status.
- Fork 560
Promote int to float for tanh operation (consistent with Pytorch) #6166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wonjoo-wj
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Let's wait until CI is green before merging.
ManfeiBai
added a commit
to ManfeiBai/PyTorchXLA
that referenced
this pull request
Dec 15, 2023
ManfeiBai
added a commit
to ManfeiBai/PyTorchXLA
that referenced
this pull request
Dec 26, 2023
ManfeiBai
added a commit
to ManfeiBai/PyTorchXLA
that referenced
this pull request
Dec 27, 2023
ManfeiBai
added a commit
to ManfeiBai/PyTorchXLA
that referenced
this pull request
Dec 27, 2023
golechwierowicz
pushed a commit
that referenced
this pull request
Jan 12, 2024
ManfeiBai
added a commit
to ManfeiBai/PyTorchXLA
that referenced
this pull request
Jan 19, 2024
ManfeiBai
added a commit
to ManfeiBai/PyTorchXLA
that referenced
this pull request
Jan 19, 2024
bhavya01
pushed a commit
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5903
test_aten_tanh_2failed due to:and tested
torch.tanhwith PyTorch and PyTorch/XLA found tanh support int in torch and didn't support int in torch_xla:and
so promote int to flost for tanh operation (consistent with PyTorch) like #4333
Testing: