Skip to content

Conversation

@chunnienc
Copy link
Collaborator

Fixes #5990

Does nothing to fix this. It just works.

(venv) cnchan@121d33c4909a:/repo/pytorch/xla$ pytest test/test_core_aten_ops.py -k test_aten_minimum
========================================================================= test session starts ==========================================================================
platform linux -- Python 3.10.12, pytest-7.4.3, pluggy-1.3.0
rootdir: /repo/pytorch
configfile: pytest.ini
plugins: xdist-3.5.0, hypothesis-6.92.0
collected 518 items / 515 deselected / 3 selected                                                                                                                      

test/test_core_aten_ops.py WARNING: All log messages before absl::InitializeLog() is called are written to STDERR
I0000 00:00:1702622994.407233 2818409 cpu_client.cc:370] TfrtCpuClient created.
...                                                                                                                                   [100%]

================================================================== 3 passed, 515 deselected in 3.55s ===================================================================
I0000 00:00:1702622995.316901 2818409 cpu_client.cc:373] TfrtCpuClient destroyed.

@chunnienc chunnienc requested a review from wonjoo-wj December 15, 2023 06:55
Copy link
Collaborator

@wonjoo-wj wonjoo-wj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha nice, we had a couple of these -- I don't know exactly why but maybe some changes/fixes on main branch fixed it lol. Anyways, thanks!

LGTM. let's wait for the CI to be green before merging this.

@chunnienc chunnienc merged commit 8a0b2ea into master Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Core ATen Opset] Lower aten_minimum

3 participants