Skip to content

Conversation

qihqi
Copy link
Collaborator

@qihqi qihqi commented Jan 22, 2024

After pytorch/pytorch#117528 export doesn't accept callables anymore.

@qihqi qihqi requested a review from zpcore January 22, 2024 18:29
Copy link
Member

@zpcore zpcore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Cool

Copy link
Collaborator

@ManfeiBai ManfeiBai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks, Han!

JackCaoG added a commit to pytorch/pytorch that referenced this pull request Jan 22, 2024
XLA CI is currently broken in PyTorch, I think there are 2 reasons causing that
1. There is an offending Pytorch PR c393b2f. Han is working on a fix in pytorch/xla#6345
2. Commit that pytorch pin to 2990cb38c17e06d0dbe25437674ca40130d76a8f was not a valid commit. I think this is because we tried to help them to land a breaking pr in pytorch/xla#6307. However I think we did a rebase which vanish that commit. now the CI failed 
```
fatal: reference is not a tree: 2990cb38c17e06d0dbe25437674ca40130d76a8f
585
```
Let me first update the pin to the master so it at least run some test, this way we can discover if there is any additional issue. I will rebase after @qihqi 's fix passed all CI
@qihqi qihqi force-pushed the qihqi/core_aten_ops branch from 61c5d04 to 3e41620 Compare January 22, 2024 22:22
@qihqi qihqi force-pushed the qihqi/core_aten_ops branch from 3e41620 to 4691231 Compare January 22, 2024 23:03
@zpcore zpcore merged commit 1c22fe3 into master Jan 23, 2024
pytorchmergebot pushed a commit to pytorch/pytorch that referenced this pull request Jan 23, 2024
XLA CI is currently broken in PyTorch, I think there are 2 reasons causing that
1. There is an offending Pytorch PR c393b2f. Han is working on a fix in pytorch/xla#6345
2. Commit that pytorch pin to 2990cb38c17e06d0dbe25437674ca40130d76a8f was not a valid commit. I think this is because we tried to help them to land a breaking pr in pytorch/xla#6307. However I think we did a rebase which vanish that commit. now the CI failed
```
fatal: reference is not a tree: 2990cb38c17e06d0dbe25437674ca40130d76a8f
585
```
Let me first update the pin to the master so it at least run some test, this way we can discover if there is any additional issue. I will rebase after @qihqi 's fix passed all CI

Fixes #ISSUE_NUMBER

Pull Request resolved: #117999
Approved by: https://github.com/clee2000
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants