[scan] Support different output dtypes #8530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating the output tensor holding the result of a `scan`, I forgot to specify the dtype, leading to all of them having the default dtype. Here we add a test and add the single missed line.
qihqi
approved these changes
Jan 4, 2025
qihqi
pushed a commit
that referenced
this pull request
Jan 16, 2025
tengyifei
added a commit
that referenced
this pull request
Jan 22, 2025
This was referenced Jan 22, 2025
Merged
tengyifei
added a commit
that referenced
this pull request
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating the output tensors holding the result of a
scan, I forgot to specify the dtype, leading to all of them having the default dtype. It turns out bfloat16 is quite popular in LLMs so we need to support that.Here we add a test and add the single missed line.