Skip to content

Conversation

@bhavya01
Copy link
Collaborator

@bhavya01 bhavya01 commented Oct 7, 2025

Using the manylinux_2_28_x86_64 tag guarantees that the built wheel works for any linux distribution with glibc version >= 2.28

If this is not used, then the built wheel is not guaranteed to work on linux distributions other than what the build infra uses.

See manylinux for more details

Copy link
Collaborator

@zhanyong-wan zhanyong-wan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Bhavya, could you document in the PR description why we need to do this? Thanks.

@bhavya01
Copy link
Collaborator Author

bhavya01 commented Oct 7, 2025

Hi Bhavya, could you document in the PR description why we need to do this? Thanks.

Done

@bhavya01 bhavya01 requested a review from zhanyong-wan October 7, 2025 19:25
Copy link
Collaborator

@zhanyong-wan zhanyong-wan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bhavya01 bhavya01 merged commit be96adf into r2.9 Oct 8, 2025
24 checks passed
rajkthakur pushed a commit to rajkthakur/xla that referenced this pull request Oct 21, 2025
Using the `manylinux_2_28_x86_64` tag guarantees that the built wheel
works for any linux distribution with glibc version >= 2.28

If this is not used, then the built wheel is not guaranteed to work on
linux distributions other than what the build infra uses.

See [manylinux](https://github.com/pypa/manylinux?tab=readme-ov-file)
for more details

Co-authored-by: Yukio Siraichi <yukio.siraichi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants