Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure plot is rendered into last output in notebook cell #2677

Merged
merged 1 commit into from
May 14, 2018

Conversation

philippjfr
Copy link
Member

This PR ensures that plots are rendered into the last output in a notebook cell ensuring that multiple outputs can be rendered with the IPython display function.

@philippjfr philippjfr changed the title Ensure plot is rendered into last output in notebook Ensure plot is rendered into last output in notebook cell May 12, 2018
@philippjfr
Copy link
Member Author

Ready to merge.

@jlstevens
Copy link
Contributor

Tests are green and the change makes sense. I'm not too happy about having to interact with the output display machinery at such a low level but I guess it is unavoidable.

Merging.

@jlstevens jlstevens merged commit 1eed30d into master May 14, 2018
@philippjfr philippjfr deleted the fix_nb_display branch July 4, 2018 11:14
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants