Deprecation: Fix ptp --> np.ptp for numpy 2.0.0 #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…precationsWarning
Member
Author
|
@hakonanes If you want to review/merge this I can start the process of making a numpy 2.0.0 patch release. |
Closed
hakonanes
reviewed
Oct 9, 2024
hakonanes
reviewed
Oct 9, 2024
|
|
||
| from diffsims.utils._deprecated import deprecated, deprecated_argument | ||
|
|
||
| if np.__version__ >= "2.0.0": |
Member
There was a problem hiding this comment.
Instead of repeating this three places, I suggest to add a private diffsims.constants module like we've done in orix: https://github.com/pyxem/orix/blob/develop/orix/constants.py. We can then import this warning from diffsims.constants import VisibleDeprecationWarning.
hakonanes
approved these changes
Oct 9, 2024
Member
hakonanes
left a comment
hakonanes
left a comment
There was a problem hiding this comment.
Two minor suggestions. Not required for merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Support numpy 2.0.0
Progress of the PR
For reviewers
__init__.py.unreleased section in
CHANGELOG.rst.creditsindiffsims/release_info.pyandin
.zenodo.json.