Feature - ZAP map #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto zap-map-2 Get's a different local ZAP MAP
ZAP MAP code, avoiding emails.
dnjohnstone
approved these changes
Feb 6, 2020
Member
dnjohnstone
left a comment
dnjohnstone
left a comment
There was a problem hiding this comment.
Thanks @pc494 - this looks good to me, the only thing I'd question is whether or not this should be a Generator class given it takes a structure and other info. But I'm not so bothered about that and will merge this as is to move forwards.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Feature - ZAP map
about: Addressing #7 and adding functionality that will resolve #51
Release Notes
What does this PR do? Please describe and/or link to an open issue.
This is a WIP that will eventually provide:
An automated method for inspecting zone axis patterns
In doing so create the tools needed to make
get_grid_around_beam_directionsmoothAre there any known issues? Do you need help?
Feedback on exactly what should be input/output would be good, currently I'm expecting to return a dictionary that can then be plotted (or inserted into a plotting function if needs be). Is this a good design?