-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fix: skipped column style bug in StreamWriter's SetRow #2235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
xuri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR. I've left some comments.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2235 +/- ##
=======================================
Coverage 99.34% 99.34%
=======================================
Files 32 32
Lines 25616 25616
=======================================
Hits 25449 25449
Misses 89 89
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I only see a single comment, which you made changes to fix. |
c2c286e to
890b442
Compare
|
Yeah, another suggestion was change |
xuri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for your contribution.
|
Thanks for quickly fixing and merging this 👍🏻 |
PR Details
There was a small bug in
StreamWriter'sSetRow, where the column styles where not applied due to a missing col increment inprepareCellStyleDescription
Properly added the index value
ito the column numbercolbefore passing toprepareCellStyleRelated Issue
Motivation and Context
It solves missing column styles when there are no cell or row styles.
How Has This Been Tested
updated the
TestStreamSetRowWithStyletest to include a check for the column styleTypes of changes
Checklist