Skip to content

Conversation

@radam9
Copy link
Contributor

@radam9 radam9 commented Nov 11, 2025

PR Details

There was a small bug in StreamWriter's SetRow, where the column styles where not applied due to a missing col increment in prepareCellStyle

Description

Properly added the index value i to the column number col before passing to prepareCellStyle

Related Issue

Motivation and Context

It solves missing column styles when there are no cell or row styles.

How Has This Been Tested

updated the TestStreamSetRowWithStyle test to include a check for the column style

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@xuri xuri added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 12, 2025
Copy link
Member

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. I've left some comments.

@xuri xuri moved this to Bugfix in Excelize v2.10.1 Nov 12, 2025
@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.34%. Comparing base (bfa81ac) to head (890b442).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2235   +/-   ##
=======================================
  Coverage   99.34%   99.34%           
=======================================
  Files          32       32           
  Lines       25616    25616           
=======================================
  Hits        25449    25449           
  Misses         89       89           
  Partials       78       78           
Flag Coverage Δ
unittests 99.34% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@radam9
Copy link
Contributor Author

radam9 commented Nov 12, 2025

Thanks for your PR. I've left some comments.

I only see a single comment, which you made changes to fix.

@xuri
Copy link
Member

xuri commented Nov 13, 2025

Yeah, another suggestion was change valueXX to cell coordinates name in test to made verification convenience. I also updated this in the last commit.

Copy link
Member

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution.

@xuri xuri merged commit 8bf639c into qax-os:master Nov 13, 2025
17 checks passed
@github-project-automation github-project-automation bot moved this from Bugfix to Miscellaneous in Excelize v2.10.1 Nov 13, 2025
@xuri xuri moved this from Miscellaneous to Bugfix in Excelize v2.10.1 Nov 13, 2025
@radam9
Copy link
Contributor Author

radam9 commented Nov 13, 2025

Thanks for quickly fixing and merging this 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

Status: Bugfix

Development

Successfully merging this pull request may close these issues.

2 participants