Skip to content

Conversation

@jenniferboedker
Copy link
Contributor

Changes
Add the equals and hash annotation to compare products

Copy link
Contributor

@Steffengreiner Steffengreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jenniferboedker jenniferboedker merged commit 26a5f5f into development Dec 14, 2020
@jenniferboedker jenniferboedker deleted the feature/products-add-equals branch December 14, 2020 13:42
KochTobi added a commit that referenced this pull request Feb 15, 2021
2.0.0 (2021-02-15)
---------------------------

**Added**

* Introduce profiles to pom to differentiate between OSGI and non-OSGI packaging (`#122 <https://github.com/qbicsoftware/data-model-lib/pull/122>`_)
* Added a netPrice, taxes and overheads property to the offer DTO
* Add bnd.bnd file to enable OSGI bundling
* Add new possible sample statuses (`#149 <https://github.com/qbicsoftware/data-model-lib/pull/149>`_)
* Add price fields to ``life.qbic.datamodel.dtos.business.Offer`` (`#127 <https://github.com/qbicsoftware/data-model-lib/pull/127>`_)
* Add currency field to ``life.qbic.datamodel.dtos.business.services.Product`` (`#131 <https://github.com/qbicsoftware/data-model-lib/pull/131>`_)
* Add ``@EqualsAndHashCode`` to ``life.qbic.datamodel.dtos.business.services.*`` (`#129 <https://github.com/qbicsoftware/data-model-lib/pull/129>`_)
* Add a meaningful ``toString()`` method to ``life.qbic.datamodel.dtos.business.TomatoId`` (`#140 <https://github.com/qbicsoftware/data-model-lib/pull/140>`_)
* Add ``life.qbic.datamodel.dtos.business.AcademicTitle.PHD`` (`#144 <https://github.com/qbicsoftware/data-model-lib/pull/144>`_)
* Add ``life.qbic.datamodel.dtos.business.ProductId`` attribute to Product DTOs in ``life.qbic.datamodel.dtos.business.services`` (`#146 <https://github.com/qbicsoftware/data-model-lib/pull/146>`_)

**Fixed**

* ``life.qbic.datamodel.datasets.OxfordNanoporeMeasurement#extractLibraryKit(String)`` now throws
  ``MissingPropertyException`` instead of ``groovyjarjarcommonscli.MissingArgumentException``
* Change ``life.qbic.datamodel.dtos.business.services.ProductUnit.PER_GIGABYTE`` String representation to `Gigabyte` (`#125 <https://github.com/qbicsoftware/data-model-lib/pull/125>`_)
* Change ``life.qbic.datamodel.dtos.business.TomatoId`` and extending classes now provide the version as ``String`` (`#134 <https://github.com/qbicsoftware/data-model-lib/pull/134>`_)
* Add missing dependencies for report generation. Fix issue `#145 <https://github.com/qbicsoftware/data-model-lib/issues/145>`_ with PR `#147 <https://github.com/qbicsoftware/data-model-lib/pull/147>`_


**Dependencies**

* Add bnd-maven-plugin 5.1.2 to support OSGI packaging
* Add maven-jar-plugin 3.2.0 to support OSGI packaging
* Add ``org.osgi:osgi.core:jar:7.0.0``
* Remove ``parent-pom:3.1.3``
* Remove ``io.swagger.core.v3:swagger-annotations:jar:2.0.8``
* Upgrade  ``com.fasterxml.jackson.core:jackson-annotations:jar:2.9.9`` -> ``2.12.0``
* Upgrade ``info.picocli:picocli:jar:3.7.0`` -> ``4.0.1``
* Upgrade ``junit:junit:jar:4.12`` -> ``junit:junit:jar:4.13``
* Upgrade ``org.codehaus.groovy:groovy-all:pom:2.5.7`` -> ``2.5.10``
* Upgrade ``org.codehaus.groovy:groovy-ant:jar:2.5.7`` -> ``2.5.10``
* Upgrade ``org.codehaus.groovy:groovy-cli-commons:jar:2.5.7`` -> ``2.5.10``
* Upgrade ``org.codehaus.groovy:groovy-cli-picocli:jar:2.5.7`` -> ``2.5.10``
* Upgrade ``org.codehaus.groovy:groovy-console:jar:2.5.7`` -> ``2.5.10``
* Upgrade ``org.codehaus.groovy:groovy-datetime:jar:2.5.7`` -> ``2.5.10``
* Upgrade ``org.codehaus.groovy:groovy-docgenerator:jar:2.5.7`` -> ``2.5.10``
* Upgrade ``org.codehaus.groovy:groovy-groovydoc:jar:2.5.7`` -> ``2.5.10``
* Upgrade ``org.codehaus.groovy:groovy-groovysh:jar:2.5.7`` -> ``2.5.10``
* Upgrade ``org.codehaus.groovy:groovy-jmx:jar:2.5.7`` -> ``2.5.10``
* Upgrade ``org.codehaus.groovy:groovy-json:jar:2.5.7`` -> ``2.5.10``
* Upgrade ``org.codehaus.groovy:groovy-jsr223:jar:2.5.7`` -> ``2.5.10``
* Upgrade ``org.codehaus.groovy:groovy-macro:jar:2.5.4`` -> ``2.5.10``
* Upgrade ``org.codehaus.groovy:groovy-nio:jar:2.5.4`` -> ``2.5.10``
* Upgrade ``org.codehaus.groovy:groovy-servlet:jar:2.5.7`` -> ``2.5.10``
* Upgrade ``org.codehaus.groovy:groovy-sql:jar:2.5.7`` -> ``2.5.10``
* Upgrade ``org.codehaus.groovy:groovy-swing:jar:2.5.7`` -> ``2.5.10``
* Upgrade ``org.codehaus.groovy:groovy-templates:jar:2.5.4`` -> ``2.5.10``
* Upgrade ``org.codehaus.groovy:groovy-test:jar:2.5.4`` -> ``2.5.10``
* Upgrade ``org.codehaus.groovy:groovy-xml:jar:2.5.4`` -> ``2.5.10``
* Upgrade ``org.codehaus.groovy:groovy:jar:2.5.4`` -> ``2.5.10``

**Deprecated**

* ``life.qbic.datamodel.dtos.business.TomatoId#getIdentifier`` is replaced by ``life.qbic.datamodel.dtos.business.TomatoId#toString``
* ``life.qbic.datamodel.dtos.general.Person#personType`` is deprecated. Please subclass this class instead of using this property.

**Removed**

* ``life.qbic.datamodel.workflows.*``
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants