Add List of ProductItems and their Net Prices associated with Overhead Pricing to Offer DTO #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ost and net price fields to Offer DTO
jenniferboedker
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR Introduces 4 new Fields to the Offer DTO which are necessary fot the final Offer document.
It also updates the Offer DTO Testing to account for the new fields.
Additional Information
Currently the final Offer just lists the ProductItems one after the other. The new version should be able to distinct the provided services into ProductItems with an associated Overhead cost and ProductItems without an associated Overhead cost. Therefore for both cases the netSum and ProductItem List should be transferable from the Offer entitity to the PDF Conversion