adapt available statuses for sample tracking #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wow-such-code
commented
Mar 17, 2021
wow-such-code
commented
- add statuses SAMPLE_RECEIVED, LIBRARY_PREP_FINISHED, DATA_AVAILABLE
- deprecate DATA_AT_QBIC status
KochTobi
requested changes
Mar 17, 2021
There was a problem hiding this comment.
Hi @wow-such-code code-wise this looks good. However, I would ask you to include a bit of javadoc for the changes introduced. Also, I would like you to add your changes to the CHANGELOG.rst
Co-authored-by: Tobias Koch <KochTobi@users.noreply.github.com>
…bicsoftware/data-model-lib into feature/update-sample-statuses
KochTobi
requested changes
Mar 17, 2021
Co-authored-by: Tobias Koch <KochTobi@users.noreply.github.com>
Co-authored-by: Tobias Koch <KochTobi@users.noreply.github.com>
KochTobi
approved these changes
Mar 17, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.