Skip to content

Add pxp product units #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 7, 2021
Merged

Add pxp product units #215

merged 9 commits into from
Jun 7, 2021

Conversation

jenniferboedker
Copy link
Contributor

@jenniferboedker jenniferboedker commented Jun 7, 2021 •
edited by KochTobi
Loading

Adds the new product types for the proteomics platform:

  • PER_HOUR("Hour"),
  • PER_PROJECT("Project"),
  • PER_RUN("Run"),
  • PER_CYCLE("Cycle"),
  • PER_GEL("Gel/HpH"),
  • PER_10_MG("10 milligram"),
  • PER_MEASUREMENT("Measurement"),
  • PER_CHANNEL("Channel"),
  • PER_100_MICROGRAM_PEPTIDE_CHANNEL("100 microgram peptides channel"),
  • PER_500_ML("500 milliliter"),
  • PER_COMPARISON("Comparison")

@jenniferboedker jenniferboedker requested a review from a team June 7, 2021 11:45
@luiskuhn
Copy link
Contributor

luiskuhn commented Jun 7, 2021

The modifications to ProductUnit.groovy look straightforward to me

luiskuhn
luiskuhn previously approved these changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@luiskuhn luiskuhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the addition of these new types looks fine

KochTobi
KochTobi requested changes Jun 7, 2021
View reviewed changes
@jenniferboedker @KochTobi
Apply suggestions from code review
ea4a8b9 
Co-authored-by: Tobias Koch <KochTobi@users.noreply.github.com>
KochTobi
KochTobi reviewed Jun 7, 2021
View reviewed changes
@jenniferboedker @KochTobi
Apply suggestions from code review
07d0512 
Co-authored-by: Tobias Koch <KochTobi@users.noreply.github.com>
@jenniferboedker @KochTobi
correct typo
1be82a6 
Co-authored-by: Tobias Koch <KochTobi@users.noreply.github.com>
@jenniferboedker jenniferboedker requested a review from KochTobi June 7, 2021 12:17
KochTobi
KochTobi reviewed Jun 7, 2021
View reviewed changes
KochTobi
KochTobi reviewed Jun 7, 2021
View reviewed changes
jenniferboedker and others added 2 commits June 7, 2021 14:22
@jenniferboedker @KochTobi
Reformat comment in CHANGELOG.rst
6046629 
Co-authored-by: Tobias Koch <KochTobi@users.noreply.github.com>
@KochTobi
Update Changelog
b165146
KochTobi
KochTobi approved these changes Jun 7, 2021
View reviewed changes
Copy link
Member

@KochTobi KochTobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jenniferboedker
Copy link
Contributor Author

We will wait with merging until we have the final list of units

@jenniferboedker jenniferboedker merged commit f143b4f into development Jun 7, 2021
@jenniferboedker jenniferboedker deleted the feature/add-pxp-product-units branch June 7, 2021 13:15
This was referenced Jun 7, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KochTobi KochTobi KochTobi approved these changes

@luiskuhn luiskuhn luiskuhn left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jenniferboedker @luiskuhn @KochTobi