Dm 33/add and adapt necessary dtos #265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KochTobi
reviewed
Oct 26, 2021
KochTobi
requested changes
Oct 26, 2021
Contributor
KochTobi
left a comment
KochTobi
left a comment
There was a problem hiding this comment.
Nice work, some comments to the implementation to make it more readable.
The only thing I would like you to change is to avoid the deprecated constructor call.
src/main/groovy/life/qbic/datamodel/dtos/business/ProductId.groovy
Outdated
Show resolved
Hide resolved
src/main/groovy/life/qbic/datamodel/dtos/business/ProductId.groovy
Outdated
Show resolved
Hide resolved
KochTobi
reviewed
Oct 26, 2021
src/main/groovy/life/qbic/datamodel/dtos/business/ProductId.groovy
Outdated
Show resolved
Hide resolved
KochTobi
approved these changes
Oct 26, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements ProductType Factory and ProductId From String method