Feature/omero prep release v1 #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
luiskuhn
commented
Mar 17, 2021
luiskuhn
commented
- added config file for omero credentials
- added basic metadata validation (placeholder function for parser object)
- made conda env. setting easy to set
- tested full registration (omero + openBis)
wow-such-code
requested changes
Mar 17, 2021
Member
wow-such-code
left a comment
wow-such-code
left a comment
There was a problem hiding this comment.
looking great, just one comment (question)
nice Co-authored-by: wow-such-code <andreas.friedrich@uni-tuebingen.de>
Contributor
Author
|
nice commit logs :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.