Add function to generate modulated Gaussian control #110
Conversation
|
I think I might be missing some context here about why we're transferring this to Open Controls? |
User guide is using old API to generate noise characterization pulses, which we want to get rid of. |
| }, | ||
| ) | ||
|
|
||
| segment_start_times = np.arange(0, duration, minimum_segment_duration) |
There was a problem hiding this comment.
Given that it's a specified duration but only a minimum segment duration, I think instead we should use slightly longer segment lengths so that we get a pulse of duration duration exactly:
segment_count = int(np.ceil(duration / minimum_segment_duration))
segment_start_times = np.arange(segment_count) * duration / segment_count # or similar
...
There was a problem hiding this comment.
That's right, sorry I missed that point. Fixed.
| base_gaussian_segments | ||
| ) | ||
| maximum_rotation_angle = ( | ||
| minimum_segment_duration |
There was a problem hiding this comment.
If you make the suggested change above, this would become segment_duration
leoadec
left a comment
leoadec
left a comment
There was a problem hiding this comment.
The code looks good, I just have two suggestions.
I don't think I have the authority to oversee the transfer of code from a private repo to an open source project, so I'll let @charmasaur give the final thumbs up here
| ) | ||
|
|
||
| # work out exact segment duration | ||
| segment_num = int(np.ceil(duration / minimum_segment_duration)) |
There was a problem hiding this comment.
Yeah, somehow I always pick segment_num
| base_gaussian_segments = (1.0 / gaussian_width / np.sqrt(2 * np.pi)) * np.exp( | ||
| -0.5 * ((segment_midpoints - gaussian_mean) / gaussian_width) ** 2 | ||
| ) |
There was a problem hiding this comment.
My opinion of this back when it was part of Core is that the normalization constant 1.0 / gaussian_width / np.sqrt(2 * np.pi) isn't necessary because the pulse gets normalized again anyway
This function should be the same as the one in core with some tweaks. We expect users to use it to generate amplitude noise characterization pulses.
Tests are migrated and modified a bit.