Make individual driven controls functions public #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the private function names I've opted to make them consistent with the scheme names, since those are presumably the most natural ways to refer to them. Plan is to make the private functions public, and document those functions with full details. Eventually we can probably delete the new_predefined_driven_control, although it's fine to stick around for a while for compatibility purposes. https://q-ctrl.atlassian.net/browse/QENG-1118
The amplitudes and Rabi rates are supposed to be given in proportion to the maximum Rabi rate: https://docs.q-ctrl.com/wiki/output-data-formats#q-ctrl-hardware https://q-ctrl.atlassian.net/browse/QENG-1118
Largely based on the wiki, although some of the references have been fixed, and the description of WAMF1 now more accurately matches the code. https://q-ctrl.atlassian.net/browse/QENG-1118
charmasaur
force-pushed
the
QENG-1118
branch
from
b6f7807 to
4a24742
Compare
Co-authored-by: Leonardo Andreta de Castro <leonardo.andreta@q-ctrl.com>
Co-authored-by: Leonardo Andreta de Castro <leonardo.andreta@q-ctrl.com>
Co-authored-by: Leonardo Andreta de Castro <leonardo.andreta@q-ctrl.com>
Co-authored-by: Leonardo Andreta de Castro <leonardo.andreta@q-ctrl.com>
charmasaur
changed the title
tachikoma-li
approved these changes
Sep 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way they can be properly documented, and will be more type-safe if we ever need different parameters for different functions.
https://q-ctrl.atlassian.net/browse/QENG-1118