Removing setup-poetry.sh #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charmasaur
previously approved these changes
Oct 23, 2020
cfarrend
reviewed
Oct 23, 2020
Member
Author
|
@cfarrend I think the only reason why this script still exists is because it is mentioned in the README as part of the installation instructions (https://github.com/qctrl/python-open-controls#from-source). That said, I'd be happy to just update the README and delete the script |
Contributor
|
This script may have been created when Poetry was still in its infancy. I think referring to the official installation instructions will be more useful https://python-poetry.org/docs/#installation as it contains instructions Linux, OSX and Windows So yeah I'd say removing the script and suggesting the official install docs may be better for collaborators |
Member
Author
|
Sounds good, I've removed the file and removed any mentions of it from the documentation. |
leoadec
changed the title
charmasaur
approved these changes
Oct 23, 2020
cfarrend
approved these changes
Oct 23, 2020
tachikoma-li
pushed a commit
that referenced
this pull request
Oct 26, 2020
* Removing setup-poetry.sh . * Updating documentation to not mention setup-poetry.sh as the method to install poetry. Co-authored-by: Q-CTRL DevOps <devops@q-ctrl.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
poetry-setup.pyscript only detects an installation of poetry if it is in version 0.12.x. However, poetry has been in version 1.x for a while now. This pull request updates the script accordingly.