Skip to content

Conversation

@hughhm
Copy link
Contributor

@hughhm hughhm commented Sep 30, 2021

@hughhm hughhm marked this pull request as ready for review October 7, 2021 00:00
@hughhm hughhm requested a review from a team October 7, 2021 00:00
abenseny
abenseny previously approved these changes Oct 7, 2021
Copy link
Member

@abenseny abenseny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a small comment.

docs/conf.py Outdated
# list see the documentation: https://www.sphinx-doc.org/en/master/usage/configuration.html
"""

# Configuration file for the Sphinx documentation builder.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is now repeated in the module docstring and as a comment. Do we need both?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really, i was a little torn about including that whole message below in the module docstring or disabling the docstring entirely. I think ill get rid of the additional comment and keep the docstring however

@hughhm hughhm merged commit 5e9fa30 into master Oct 7, 2021
@hughhm hughhm deleted the DEVOPS-696 branch October 7, 2021 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants