Skip to content

feat: Add support for Python 3.10 #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Feb 11, 2022
Merged

feat: Add support for Python 3.10 #203

merged 24 commits into from
Feb 11, 2022

Conversation

@leoadec
Copy link
Member

@leoadec leoadec commented Oct 15, 2021 •
edited
Loading

Changes proposed in this pull request:

  • Make package compatible with Python 3.10.
  • Include Python 3.10 in the unit tests.
  • Update version of pytest.

tachikoma-li
tachikoma-li reviewed Oct 15, 2021
View reviewed changes
Copy link
Member

@tachikoma-li tachikoma-li left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might explain why CI fails.
It seems we do use get-poetry.py here. Shall we file a ticket for dev team? @leoadec

@leoadec
Copy link
Member Author

leoadec commented Oct 15, 2021

Thanks @tachikoma-li ! I think you're right, I'll ping devops about it on Monday

@leoadec leoadec closed this Nov 11, 2021
@leoadec leoadec deleted the py310 branch November 11, 2021 22:55
@leoadec leoadec restored the py310 branch February 11, 2022 02:53
@leoadec leoadec reopened this Feb 11, 2022
tachikoma-li
tachikoma-li reviewed Feb 11, 2022
View reviewed changes
tachikoma-li
tachikoma-li approved these changes Feb 11, 2022
View reviewed changes
Copy link
Member

@tachikoma-li tachikoma-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@leoadec leoadec marked this pull request as ready for review February 11, 2022 06:10
@leoadec leoadec requested review from a team February 11, 2022 06:10
@leoadec leoadec merged commit ff47d86 into master Feb 11, 2022
@leoadec leoadec deleted the py310 branch February 11, 2022 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tachikoma-li tachikoma-li tachikoma-li approved these changes

+1 more reviewer

@cfarrend cfarrend cfarrend approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@leoadec @cfarrend @tachikoma-li @qctrlrobot