Skip to content

Conversation

@tachikoma-li
Copy link
Member

Changes proposed in this pull request:

  • Remove dephell and setup.py
  • Update README

@tachikoma-li tachikoma-li requested a review from leoadec March 18, 2022 05:03
@tachikoma-li tachikoma-li marked this pull request as ready for review March 18, 2022 05:03
@tachikoma-li tachikoma-li requested a review from a team March 18, 2022 05:03
poetry install
```

1. Using pip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Using pip
2. Using pip

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are automatically numbered.

Copy link
Member

@leoadec leoadec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just have a question


```shell
cd python-open-controls
python setup.py develop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems to be difficult to run without setup.py

Copy link
Member

@leoadec leoadec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎏

@tachikoma-li tachikoma-li merged commit f0c3ed2 into master Mar 18, 2022
@tachikoma-li tachikoma-li deleted the remove-setup-py branch March 18, 2022 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants