[WIP] References to issues updated in code comments #30014
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of only showing the raw values, show also the represented values in the expression builder in the list values preview. This helps people to choose from readable values (whereas still the raw values get inserted on double click).
|
@jef-n Can you please review this PR? (The |
qgis#29895) This fix display of full circles coming from PostGIS.
There was a lack of a JSon array around rings of a polygon.
This issue is not present in 3.4
Also fixes an issue with gcc 5.5 of Ubuntu 16.04 that doesn't behave
properly with C++11 brace syntax with code from nlohmann/json.hpp.
The code compiles but the result is invalid: `json foo{ json::array{} }`
is serialized as [[]] instead of []. So use old-style constructor
instead: `json foo( json::array() )`
This PR is on top of qgis#30010
Avoid redundant network requests when cloning data provider
to changes in connection parameters And modernise code, sync with AFS provider
server structures
conjunction with the "merge connected lines" setting Refs qgis#12173
with line networks that contains forks and branches And simplify memory management Refs qgis#12173
Avoid duplicate calculations
where the label length is greater then the line length
begins with small segments Fixes qgis#28699
…ightly to encourage more central placements)
set to above line only
when linked map is rotated The rotation wasn't being taken into account, which meant that visible features weren't shown (and vice versa)
Whenever a https network request is created, QgsAuthManager::sslCertCustomConfigByHost is used to alter the ssl configuration according to config stored within the sqlite authentication database. This results in a database query being created for EVERY request, regardless of whether a user actually has any ssl configuration set. Instead, use a cache to avoid firing off this db query for every request
…by one Otherwise we often exceed the maximum size of a get query
when atlas feature has a different CRS to table layer And greatly improve performance when using an attribute table filtered to the atlas feature
layer rectangle to the background of the icon to give a visual hint of this Otherwise it's easy to mistake the action as a full map-based action
other layer-related zoom actions Instead of sitting next to global map based zoom actions
Co-Authored-By: Matthias Kuhn <matthias@opengis.ch>
Fix json hanlding of bools and complete json(b) PG support
…on-widget-match-name-if-id-fails When loading a QLR, try to match the layer name if id does not
…itches [cad] fix graphical glitches
…ap-issue-references Resolve merge conflits
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does only changes comments. It replaces old references to Redmine issues with the new reference to GitHub issues.
Even old issues will have new comments in GitHub and not on Redmine. Redmine will became deprecated. Better to do this change while we are aware of the changes we made and we have the issue map around.
To find issues in the code, I did:
There were 108 references. There were two links to comments:
All these occurrences were replace using
sed.The two references to comments within issues (
#note-\d) were replace manually.Checklist
fixes #11111in the commit message next to the description[FEATURE]in the commit message[needs-docs]in the commit message and contain sufficient information in the commit message to be documentedscripts/prepare-commit.shscript before each commit