Removing skbio dependency #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed scikit-bio's dependency by copying here the code that was used in scikit-bio 0.2.3. I've also adapted the needed code to work with Python 3.
We can potentially improve the code and the speed of the code here if we make the code less general. At this moment, this code is expecting a split libraries output from Qiime 1, so it is not a general FASTQ format. Given this, we may be able to speed up the parsers if we assume that the FASTQ are 4 lines per sequence. However, the amount of code copied over is significant, and I was uncomfortable doing all this optimizations at this moment.