Skip to content

Fix 1136 #1140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 1, 2015
Merged

Fix 1136 #1140

merged 4 commits into from
May 1, 2015

Conversation

@antgonza
Copy link
Member

@antgonza antgonza commented May 1, 2015

Removed all unnecessary conn_handler as parameter. Note that queues need to have the conn_handler and the queue_name, thus no removing.

@coveralls
Copy link

coveralls commented May 1, 2015

Coverage Status

Coverage decreased (-0.01%) to 79.31% when pulling 2de4acd on antgonza:fix-1136 into ef7955c on biocore:master.

@josenavas
Copy link
Contributor

josenavas commented May 1, 2015

👍
@antgonza thanks for working on this! The code in here looks good. This PR is also a good exercise, since I noticed in how many places the queues are needed and we are not using them! That is a separate issue though, and we already have an issue to keep track of that, so this is good to merge :-)

squirrelo added a commit that referenced this pull request May 1, 2015
@squirrelo
Merge pull request #1140 from antgonza/fix-1136
01ac199 
Fix 1136
@squirrelo squirrelo merged commit 01ac199 into qiita-spots:master May 1, 2015
@antgonza antgonza mentioned this pull request May 1, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@antgonza @coveralls @josenavas @squirrelo