Removing any instance of required_sample_info and common_prep_info. … #1168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lso adding a test for metadata_headers
Contributor
|
👍 |
antgonza
added a commit
that referenced
this pull request
May 8, 2015
Removing any instance of required_sample_info and common_prep_info. …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Also adding a test for metadata_headers
@wasade noticed that there was still a couple of references to the
required_sample_infoandcommon_prep_infotables. I'm removing any reference to those here.The function in which
required_sample_infowas used did not had a test. When I added a test, I noticed that the populate_test_db.sql was not consistent which what our code represents (i.e. we are not allowing to have uppercase column names) so I modified it to be consistent with the rest of our code.