ENH: Bring email validation closer to specs #1180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamrp
force-pushed
the
relax_email_validation-issue-1179
branch
from
29a5508 to
08c733e
Compare
added 3 commits
May 14, 2015 15:53
Fix qiita-spots#1179 This doesn't fully account for all valid email addresses (doing so is too much of a headache to implement, at least until it becomes necessary...), but it's closer, and will pass for the majority of email addresses.
The domain part of the email address does not have to have a dot in it; even if it did, the last domain specified cannot be assured to be a TLD.
adamrp
force-pushed
the
relax_email_validation-issue-1179
branch
from
f91d66f to
2895b30
Compare
Contributor
|
test failures, I think 👍 otherwise tho |
Contributor
Author
|
I think the only failures are the same two that are popping up on all our PRs since pandas was updated. I have a PR in for one of them #1182, but not sure about the other one 😦 |
Contributor
|
👍 once the failures are worked out |
Contributor
Author
|
Merge? |
squirrelo
added a commit
that referenced
this pull request
May 16, 2015
ENH: Bring email validation closer to specs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1179
This doesn't fully account for all valid email addresses (doing so is too
much of a headache to implement, at least until it becomes necessary...), but
it's closer, and will pass for the majority of email addresses.