Skip to content

Conversation

@YangSen-qn
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #370 into develop will decrease coverage by 3.44%.
The diff coverage is 19.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #370      +/-   ##
===========================================
- Coverage    81.06%   77.61%   -3.45%     
===========================================
  Files           83       83              
  Lines         5978     6281     +303     
===========================================
+ Hits          4846     4875      +29     
- Misses        1132     1406     +274     
Impacted Files Coverage Δ
...tp/Request/HttpClient/UrlProtocol/QNCFHttpClient.m 39.13% <0.00%> (-42.14%) ⬇️
...DK/Http/ServerRegion/QNUploadServerFreezeManager.h 100.00% <ø> (ø)
QiniuSDK/Storage/QNConfiguration.h 100.00% <ø> (ø)
QiniuSDK/Collect/QNReportItem.m 79.56% <66.66%> (-0.65%) ⬇️
...DK/Http/ServerRegion/QNUploadServerFreezeManager.m 89.36% <80.00%> (-3.98%) ⬇️
QiniuSDK/Http/ServerRegion/QNUploadDomainRegion.m 82.55% <82.60%> (-8.61%) ⬇️
QiniuSDK/Http/QNResponseInfo.m 76.82% <87.50%> (+0.22%) ⬆️
QiniuSDK/Http/Request/QNHttpRegionRequest.m 95.91% <100.00%> (-0.09%) ⬇️
QiniuSDK/Storage/QNConfiguration.m 100.00% <100.00%> (ø)
QiniuSDK/Storage/QNPartsUpload.m 85.88% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a119996...566ec01. Read the comment docs.

@YangSen-qn YangSen-qn changed the title transform CF Client error transform CF Client error & optimize host frozen logic Oct 16, 2020
return nil;
}

NSInteger errorCode = -1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YangSen-qn 这里应该用 kQNNetworkError 吧?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kQNNetworkError是在上层,所以不建议引进来

@qiniu-bot qiniu-bot added size/XL and removed size/L labels Oct 21, 2020
@bachue bachue merged commit 4ac5080 into qiniu:develop Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants