Skip to content

Conversation

@tnemoz
Copy link
Contributor

@tnemoz tnemoz commented Sep 2, 2025

Summary

As per this comment in #244, Qiskit/qiskit#14714 will only be merged in the 2.2.0 release of Qiskit. As such, Qiskit/qiskit#14567 is still a problem in the 2.1.2 release.

We thus need to simplify the commutators ourselves in AdaptVQE in this qiskit release. This was already done for the 2.1.0 and 2.1.2 releases. This PR adds the 2.1.2 release to the versions in which to perform this additional operation.

This would prevent users from encountering errors when running AdaptVQE.

Note: this doesn't preclude having to pin the qiskit version to be different than 2.1.2 in requirements-dev.txt, since Qiskit/qiskit#14611 is not fixed in the 2.1.2 release either. However, while the later may not be encountered by users, it's way less certain for this issue, as seen from the fact that even basic unit test fail to pass when using AdaptVQE with qiskit 2.1.2.

@coveralls
Copy link

coveralls commented Sep 2, 2025

Pull Request Test Coverage Report for Build 17444577394

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.194%

Totals Coverage Status
Change from base Build 17443303784: 0.0%
Covered Lines: 6659
Relevant Lines: 7383

💛 - Coveralls

@ElePT ElePT merged commit ab1f5a6 into qiskit-community:main Sep 3, 2025
16 of 18 checks passed
@tnemoz tnemoz deleted the fix_adapt_vqe_2.1.2 branch September 5, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants