Skip to content

Conversation

@chriseclectic
Copy link
Collaborator

@chriseclectic chriseclectic commented Jul 20, 2021

Summary

  • Moves BaseExperiment, BaseAnalysis, ExperimentData to the qiskit_experiments.framework module.
  • Moves the composite folder to the qiskit_experiments.framework module, ParallelExperiment and BatchExperiment should be imported from here now.
  • Adds basic documentation for creating experiment and analysis subclasses to the framework module documentation
  • Renames the analysis module to curve_analysis
  • Adds a table for modules to simplify formatting of qiskit_experiments.__init__.py.

Details and comments

TODO as a follow up is reviewing and re-organizing the contents of the curve_analysis module.

@chriseclectic chriseclectic added this to the Release 0.1 milestone Jul 20, 2021
@chriseclectic chriseclectic changed the title Add base module for base classes Add base module and curve_analysis module Jul 21, 2021
@eliarbel
Copy link
Contributor

Hi Chris, I think we should put all the framework classes together, that is the BaseExperiment and BaseAnalysis classes together with the composite directory classes. Although the composite classed won't be derived from (hence maybe we should rename base to framework) I still find it odd that we have a dedicated folder for the composite classes as I consider the base and composite classes as meta-classes in the experiments package

@chriseclectic chriseclectic changed the title Add base module and curve_analysis module Add framework module and curve_analysis module Jul 21, 2021
@chriseclectic chriseclectic merged commit d55eaa0 into qiskit-community:main Jul 21, 2021
@chriseclectic chriseclectic deleted the base branch March 3, 2022 22:43
paco-ri pushed a commit to paco-ri/qiskit-experiments that referenced this pull request Jul 11, 2022
)

Co-authored-by: Naoki Kanazawa <nkanazawa1989@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants