T2Star experiment #21
Merged
+540
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…sis. Added the function _fit_quality
Contributor
Author
|
I think this is ready for review. I probably should add more tests, but this does not block an initial review. @yaelbh - will you do this? |
Contributor
Author
|
Also - how do you get the integration tests to run? |
Contributor
Author
|
@coruscating , can you approve running the workflow? |
Contributor
Author
|
@mtreinish , can you turn on the CI so that the tests run for this PR? |
yaelbh
requested changes
May 9, 2021
yaelbh
reviewed
May 20, 2021
yaelbh
approved these changes
May 23, 2021
paco-ri
pushed a commit
to paco-ri/qiskit-experiments
that referenced
this pull request
Jul 11, 2022
* Initial class for T2StarExperiment * Initial version of Ramsey experiment * changed names Ramsey to t2star * Wrote test for t2star * Continued to develop the test for t2star * Fixed bug - missing enumerate in loop * Cleaned up documentation and add a function _format_plot * Added conversion of units to SI * Added tests for all units (except dt)) * Support for dt unit * Moved function _t2star_default_params outside the function _run_analysis. Added the function _fit_quality * Cleaning up and added hints for parameters * black * put matplotlib as optional * Removed files that were included by mistake * lint fixes * Black fixes * more lint * Removed blank line and moved pylint disable * Fixed hints, variable names * Documentation and other small fixes from review * Removed self._p0 and more cleaning * Cleaning up, comments from review * Moved comparison of p0 and freq from _fit_quality to an assert in the test * Fixed some confusion between measurement of + and measurement of 1. Increased delta * Fixed confusion regarding if measuring + or measuring 1 * Removed unnecessary definition of prob1 * Use plotting instead of matplotlib directly * black * pylint * increased delta in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added experiment for
T2*andRamsey. The result contains both the value forT2*and thefrequency.Details and comments