Add fit model to curve analysis #238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,158 +1,159 @@ | |||
| # This code is part of Qiskit. | |||
Contributor
There was a problem hiding this comment.
I'm not sure why GitHub is showing this entire file as changed.
Contributor
There was a problem hiding this comment.
My guess is it's different newline characters (windows vs unix)
| y = {\rm amp} \sin\left(2 \pi {\fm freq} x + {\rm phase}\right) + {\rm baseline} | ||
| """ | ||
| return amp * np.cos(2 * np.pi * freq * x + phase) + baseline | ||
| return amp * np.sin(2 * np.pi * freq * x + phase) + baseline |
blakejohnson
approved these changes
Aug 18, 2021
Contributor
blakejohnson
left a comment
blakejohnson
left a comment
There was a problem hiding this comment.
Looks like a nice enhancement.
added 7 commits
August 20, 2021 03:00
…ade/math_model # Conflicts: # qiskit_experiments/curve_analysis/curve_analysis.py # qiskit_experiments/curve_analysis/curve_data.py # qiskit_experiments/library/calibration/analysis/drag_analysis.py # qiskit_experiments/library/calibration/analysis/fine_amplitude_analysis.py # test/curve_analysis/test_curve_fit.py # test/randomized_benchmarking/test_rb_analysis.py
paco-ri
pushed a commit
to paco-ri/qiskit-experiments
that referenced
this pull request
Jul 11, 2022
* add fit model metadata * update curve fit test * update ub test * black * fit model description defaults to None * fix descriptions * update rb test cache files * add reno * fix typo * update reno
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds a fit model information to analysis result generated by a
CurveAnalysissubclass.Requested by @blakejohnson
Details and comments
The latex curve description is attached to
SeriesDef, which is loaded by theCurveAnalysisand attached to the analysis result. User can directly find fit model without reading analysis class API docs. Thefit_modelsfield is a dictionary with a key of curve series name (defaults to'Series-0').