-
Notifications
You must be signed in to change notification settings - Fork 131
[WIP] Integrate T1 experiment with result database #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Unlike our in-house
It appears that there was a plan to support circuit metadata in the ResultsDB (in addition to the experiment metadata), according to the ResultsDB design doc. Which option is preferable? |
Co-authored-by: Christopher J. Wood <cjwood@us.ibm.com>
|
I changed my clone of PR 5499 to pass the circuit metadata, but did not bother to filter by experiment type or id. This is how the relevant function looks like: The difference is in the addition of the line starting with |
|
I pushed some more code. It's still not working because need to figure out which index to put as an argument of |
| analysis_result = AnalysisResultV1( | ||
| result_data, | ||
| 'T1', | ||
| [Qubit()], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to enter an index here inside the parentheses
|
Almost all T1 tests are passing now, with my own version of PR 5499, which I slightly modified to allow |
| # Create new experiment data | ||
| if experiment_data is None: | ||
| experiment_data = self.__experiment_data__(self) | ||
| experiment_data = self.__experiment_data__(backend, self._type) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to pass options (e.g. share_level) to the experiment data constructor, coming from the run method kwargs.
|
Closing in favor of #66 |
Summary
Using
AnalysisResultV1andExperimentDataV1from Qiskit/qiskit#5499Details and comments
Incomplete, not working yet