Skip to content

Fix bug in curve_fit for sigma=None #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2021
Merged

Fix bug in curve_fit for sigma=None #422

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a24f42
Fix bug in curve_fit for sigma=None
chriseclectic Oct 8, 2021
ae20532
Merge branch 'main' into fix-curve-fit
chriseclectic Oct 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions qiskit_experiments/curve_analysis/curve_fit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,13 +109,14 @@ def fit_func(x, *params):
)

# Format non-number sigma values
if np.all(np.isnan(sigma)):
sigma = None
else:
sigma = np.nan_to_num(sigma)
if np.count_nonzero(sigma) != len(sigma):
# Sigma = 0 causes zero division error
if sigma is not None:
if np.all(np.isnan(sigma)):
sigma = None
else:
sigma = np.nan_to_num(sigma)
if np.count_nonzero(sigma) != len(sigma):
# Sigma = 0 causes zero division error
sigma = None

# Override scipy.curve_fit default for absolute_sigma=True
# if sigma is specified.
Expand Down