Skip to content

Hack for non-existing parent id #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 26, 2021
Merged

Hack for non-existing parent id #461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4cdf235
Hack for non-existing parent id
yaelbh Oct 26, 2021
e24eb40
black
yaelbh Oct 26, 2021
bcdcc4c
Merge branch 'main' into pop_parent
chriseclectic Oct 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion qiskit_experiments/database_service/db_experiment_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -862,7 +862,7 @@ def load(cls, experiment_id: str, service: DatabaseServiceV1) -> "DbExperimentDa
experiment_type=service_data.pop("experiment_type"),
backend=service_data.pop("backend"),
experiment_id=service_data.pop("experiment_id"),
parent_id=service_data.pop("parent_id"),
parent_id=service_data.pop("parent_id", None),
tags=service_data.pop("tags"),
job_ids=service_data.pop("job_ids"),
share_level=service_data.pop("share_level"),
Expand Down
6 changes: 6 additions & 0 deletions qiskit_experiments/framework/composite/composite_experiment_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,12 @@ def load(cls, experiment_id: str, service: DatabaseServiceV1) -> "CompositeExper
load_class = globals()[comp_class]
load_func = getattr(load_class, "load")
loaded_comp = load_func(comp_id, service)

# Sub-experiments that were saved before parent_id was introduced -
# their parent_id was set to None by the super class load method,
# and has now to be updated to the correct id
loaded_comp._parent_id = expdata.experiment_id

expdata._components.append(loaded_comp)

return expdata
Expand Down