A Test for RB experiment #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItamarGoldman
changed the title
Changed names of some variables to represent better their content, added return var for experiment results. Added Test to validate the circuit data with the experiment attribute.
Few things were changed: 1. There is a function for each test experiment configuration. 2. Added transpiled circuit check using process_fidelity from qiskit.quantum_info.operators.measures 3. Changed the np.allclose to matrix_equal function to be invariant for global phase.
test/test_rb.py
Outdated
| exp_attributes = { | ||
| "qubits": [1], | ||
| "lengths": [1, 3, 5, 7, 9], | ||
| "num_samples": 1, |
Contributor
There was a problem hiding this comment.
maybe try also num_samples > 1
Contributor
|
Thanks for writing the tests! They are very good. I only had a few comments |
gadial
reviewed
May 25, 2021
Changed some experiment attributes. Added comment why every configuration that return by _exp_data_properties() should raise an exception.
Added decorator to make one function that test for different data (In this case: number of qubits)
Deleted the test for the transpiled circuit since the function doesn't exist anymore
test/test_rb.py
Outdated
| Returns: | ||
| list[dict]: list of dictionaries with experiment properties. | ||
| """ | ||
| exp_data_list = [ |
Contributor
There was a problem hiding this comment.
I think that the most common mistakes are when "lengths" is not strictly increasing, and in particular when the same length appears twice. This can happen if someone generates the length sequence using some function (e.g. a logarithmic function), see for example the discussion here:
qiskit-community/qiskit-ignis#459
I never saw errors when the "qubits" or "length" are non-positive (or non-integers)
Two function that were for the input test were deleted. No need to import QiskitError
ShellyGarion
approved these changes
May 30, 2021
paco-ri
pushed a commit
to paco-ri/qiskit-experiments
that referenced
this pull request
Jul 11, 2022
* Create test_rb.py * Update test_rb.py * Update test_rb.py * Update test_rb.py * Update test_rb.py * Added Test to validate the circuit data Changed names of some variables to represent better their content, added return var for experiment results. Added Test to validate the circuit data with the experiment attribute. * Lint fixed * Added test for transpiled circuit Few things were changed: 1. There is a function for each test experiment configuration. 2. Added transpiled circuit check using process_fidelity from qiskit.quantum_info.operators.measures 3. Changed the np.allclose to matrix_equal function to be invariant for global phase. * Update test_rb.py * Update test_rb.py * Black and lint * uncommented test * Changes in experiment attributes Changed some experiment attributes. Added comment why every configuration that return by _exp_data_properties() should raise an exception. * Added ddt decorator and use it to decrease the number of functions Added decorator to make one function that test for different data (In this case: number of qubits) * Deleted the test for the transpiled circuit Deleted the test for the transpiled circuit since the function doesn't exist anymore * Ran Black on the code * The test_rb.py passed lint (local) * Update __init__.py * Fixed the test for metadata and run experiment * Run Black * Fixed lint * Deleted - Test for input error hadling Two function that were for the input test were deleted. No need to import QiskitError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implemented 2 qubits test for meta data and check circuit functionality is identity.
#34