Fix composite experiment blocking bug #570
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Because blocking mechanism is sometime terminated before above callback is added to | ||
| # the experiment_data callback queue list, we need to extend execution time of this routine | ||
| # to ensure this will complete after the callback is actually queued. | ||
| sleep(1) |
Collaborator
There was a problem hiding this comment.
I dont think this problem is specific to composite experiment. Returning before the callback has updated the status could happen to any experiment and probably needs some tweaks in DbExperimentData.status. Adding a 1 second sleep here seems not a good solution.
Collaborator
Author
|
I wrote issue #573 instead of merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the bug that the composite experiment data blocking returns before its (child data) execution complete.
Details and comments
See comment in the code.