Fix unnecessary expdata copy for composite exps #601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseclectic
added
the
Changelog: Bugfix
Collaborator
nkanazawa1989
left a comment
nkanazawa1989
left a comment
There was a problem hiding this comment.
LGTM just minor question about update of test file.
| # Additional data not part of composite experiment | ||
| exp3 = FakeExperiment([0, 1]) | ||
| extra_data = exp3.run(FakeBackend()) | ||
| extra_data = exp3.run(FakeBackend()).block_for_results() |
Collaborator
There was a problem hiding this comment.
Is this relevant to copy?
Collaborator
Author
There was a problem hiding this comment.
This was just to be safe that the child fake experiment finishes all its analysis before later re-running analysis with replacement on the data.
chriseclectic
force-pushed
the
analysis-copy
branch
from
18a6a5c to
c8c6c71
Compare
paco-ri
pushed a commit
to paco-ri/qiskit-experiments
that referenced
this pull request
Jul 11, 2022
Fix unnecessary experiment data copy that occured when running composite analysis on composite experiment data that had not yet been analyzed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes check in BaseAnalysis for whether the ExperimentData container requires copying to avoid an unnecessary copy for empty composite experiment data containers.
Details and comments
Adds debug msg to logger so running with log level DEBUG will show when experiment data is copied