Local and correlated readout error characterization experiments #611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
gadial
changed the title
gadial
changed the title
yaelbh
reviewed
Jan 19, 2022
Collaborator
yaelbh
left a comment
yaelbh
left a comment
There was a problem hiding this comment.
- Chris says: "It doesn't include a release note saying that a new experiment was added with links to the API docs." Did you do it? I somehow don't see it.
- Please verify that it runs well on a real device.
qiskit_experiments/library/characterization/analysis/correlated_readout_error_analysis.py
Outdated
Show resolved
Hide resolved
qiskit_experiments/library/characterization/analysis/correlated_readout_error_analysis.py
Outdated
Show resolved
Hide resolved
qiskit_experiments/library/characterization/analysis/correlated_readout_error_analysis.py
Outdated
Show resolved
Hide resolved
qiskit_experiments/library/characterization/analysis/correlated_readout_error_analysis.py
Show resolved
Hide resolved
qiskit_experiments/library/characterization/analysis/local_readout_error_analysis.py
Outdated
Show resolved
Hide resolved
| qubits = experiment_data.metadata["physical_qubits"] | ||
| labels = [datum["metadata"]["label"] for datum in data] | ||
| matrix = self._generate_matrix(data, labels) | ||
| result_mitigator = CorrelatedReadoutMitigator(matrix, qubits=qubits) |
Collaborator
There was a problem hiding this comment.
I guess that trying to save the experiment will crash because CorrelatedReadoutMitigator is not serializable.
- Is this correct?
- Verify that you can save with analysis parameter set to
False, and you can load it and see it on the web. - Can we do anything that will allow us to save the result?
Collaborator
There was a problem hiding this comment.
To make these serializable we would to add settings or __json_encode__ method to them for the json serializer. We could monkey patch them in experiments to do this to make it work before they can be added to terra.
chriseclectic
requested changes
Jan 20, 2022
Collaborator
chriseclectic
left a comment
chriseclectic
left a comment
There was a problem hiding this comment.
This is looking really nice! Several comments for some small tweaks and changes
qiskit_experiments/library/characterization/analysis/correlated_readout_error_analysis.py
Outdated
Show resolved
Hide resolved
qiskit_experiments/library/characterization/analysis/correlated_readout_error_analysis.py
Show resolved
Hide resolved
qiskit_experiments/library/characterization/analysis/correlated_readout_error_analysis.py
Outdated
Show resolved
Hide resolved
qiskit_experiments/library/characterization/local_readout_error.py
Outdated
Show resolved
Hide resolved
qiskit_experiments/library/characterization/local_readout_error.py
Outdated
Show resolved
Hide resolved
qiskit_experiments/library/characterization/local_readout_error.py
Outdated
Show resolved
Hide resolved
qiskit_experiments/library/characterization/local_readout_error.py
Outdated
Show resolved
Hide resolved
qiskit_experiments/library/characterization/local_readout_error.py
Outdated
Show resolved
Hide resolved
chriseclectic
changed the title
Collaborator
|
Forgot to add that the previous release note should be edited to include the two new experiments. |
# Conflicts: # qiskit_experiments/library/__init__.py # qiskit_experiments/library/characterization/__init__.py # qiskit_experiments/library/characterization/analysis/__init__.py # qiskit_experiments/library/mitigation/mitigation_experiment.py
# Conflicts: # docs/tutorials/readout_mitigation.ipynb
chriseclectic
added
the
Changelog: New Feature
paco-ri
pushed a commit
to paco-ri/qiskit-experiments
that referenced
this pull request
Jul 11, 2022
…it-community#611) Added two new experiments LocalReadoutError and CorrelatedReadoutError for characterizing the readout error of devices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details and comments