Fix bug with json decoder for classes defined in __main__ #623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug with JSON deserialization of custom user classes defined in the __main__ scope of python scripts and notebooks. Adds JSON unittests for testing classes, methods, and functions defined in the __main__ module. The previous tests which aimed to do this were not working correctly since their module was being serialized as test.path_to_test_file instead of __main__.
chriseclectic
added
backport stable potential
chriseclectic
changed the title
Collaborator
nkanazawa1989
left a comment
nkanazawa1989
left a comment
There was a problem hiding this comment.
What is the mechanism that current logic fails? Any key mismatch when we directly look into globals?
nkanazawa1989
approved these changes
Jan 27, 2022
paco-ri
pushed a commit
to paco-ri/qiskit-experiments
that referenced
this pull request
Jul 11, 2022
Fixes a bug with JSON deserialization of custom user classes defined in the __main__ scope of python scripts and notebooks. Adds JSON unittests for testing classes, methods, and functions defined in the __main__ module. The previous tests which aimed to do this were not working correctly since their module was being serialized as test.path_to_test_file instead of __main__.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug with JSON deserialization of custom user classes defined in the
__main__scope of python scripts and notebooks.Adds JSON unittests for testing classes, methods, and functions defined in the
__main__module. The previous tests which aimed to do this were not working correctly since their module was being serialized astest.path_to_test_fileinstead of__main__.Details and comments