Fix CompositeExperiment.copy to preserve analysis referances #657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix CompositeExperiment.copy to preserve any analysis object references between the original component experiment analysis classes and the composite analysis component analysis classes.
chriseclectic
added
the
Changelog: Bugfix
nkanazawa1989
approved these changes
Feb 9, 2022
| # Check if the analysis in CompositeAnalysis was a reference to the | ||
| # original component experiment analyses and if so update the copies | ||
| # to preserve this relationship | ||
| if isinstance(self.analysis, CompositeAnalysis): |
Collaborator
There was a problem hiding this comment.
Seems like Tphi experiment unintentionally breaks this relationship. This there any safer logic for developer to notify this? This is not the scope of this PR.
https://github.com/Qiskit/qiskit-experiments/blob/66002c536777f955b7349057c0f60924d98dc940/qiskit_experiments/library/characterization/tphi.py#L104-L108
Collaborator
Author
There was a problem hiding this comment.
I'm not sure if it was intended or not for Tphi, but if analysis was supposed to be a reference line 108 should be changed to be TphiAnalysis(analyses=[exp_t1.analysis, exp_t2.analysis])
paco-ri
pushed a commit
to paco-ri/qiskit-experiments
that referenced
this pull request
Jul 11, 2022
Fix CompositeExperiment.copy to preserve any analysis object references between the original component experiment analysis classes and the composite analysis component analysis classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix bug with
CompositeExperiment.copyso that it will preserve any analysis object references between the original component experiment analysis classes and the composite analysis component analysis classes.Details and comments
Currently when a copy happens this reference is broken so that the copies component experiment analysis classes are not the same object as the analysis copies component analysis classes, even if they were in the original experiment