Restless Experiments #689

catornow · 2022-02-25T15:33:08Z

Summary

This PR implements a new class RestlessEnabledExperiment that allows users to create restless experiments without specifying all needed run options themselves.

Details and comments

For example

amp_exp = FineXAmplitude(...)
# enable a restless measurement setting.
amp_exp.enable_restless(rep_delay=1e-6)

will enable a restless measurement setting for the FineXAmplitude experiment with a repetition delay of 1 us.

eggerdj

This is looking good. Here is some feedback to improve the code.

qiskit_experiments/framework/restless_experiment.py

…s into RestlessMixin

…lessMixin

eggerdj

This is in good shape. Some things are bit unclear in the restless mock backend regarding the number of qubits that are supported.

qiskit_experiments/framework/restless_experiment.py

qiskit_experiments/test/mock_iq_backend.py

test/data_processing/test_restless_experiment.py

Co-authored-by: Daniel J. Egger <38065505+eggerdj@users.noreply.github.com>

eggerdj

This looks good to me up to the few minor things I pointed out.

qiskit_experiments/framework/restless_mixin.py

qiskit_experiments/library/characterization/fine_amplitude.py

qiskit_experiments/test/mock_iq_backend.py

test/data_processing/test_restless_experiment.py

Co-authored-by: Daniel J. Egger <38065505+eggerdj@users.noreply.github.com>

eggerdj

This is looking good. @nkanazawa1989 can you also weight in?

nkanazawa1989

Hi @catornow the design of the restless class looks nice and likely my review comments in another PR are all addressed. I'm satisfied with the overall implementation but I see some tight coupling to a particular service. I think this issue is unavoidable thus we need some validation mechanism to check if backend really supports restless operation.

qiskit_experiments/framework/restless_mixin.py

qiskit_experiments/test/mock_iq_backend.py

…ess` and modified default value

…oes not exist

eggerdj

LGTM! @nkanazawa1989 any other requested changes?

qiskit_experiments/framework/restless_mixin.py

nkanazawa1989

Looks good to me. Please check if this pass is executable and save/loadable with real backend and service before merging.

eggerdj · 2022-03-11T15:45:24Z

This runs fine:

Shots on IQX look restless

nkanazawa1989 · 2022-03-14T02:23:53Z

Looks good to go now :)

* This PR adds a restless Mixin class that allows experiments to run in the restless operation mode where qubits are not reset between two shots. The mix-in makes it easy for users to enable restless measurements and adds functionality for developers to specify restless data processor. Co-authored-by: Daniel J. Egger <38065505+eggerdj@users.noreply.github.com>

catornow added 8 commits February 22, 2022 19:07

First draft of RestlessEnabledExperiment

f2945b3

Modified the draft

9660509

Moved restless_experiment to framework folder and modified it

b7edd2a

Implemented is_restless check

d460e70

Removed restless node tests for this PR

3e8c5f3

Small modification

6ef6690

Black

7c9e1e8

Fixed Lint error

271ce98

eggerdj suggested changes Feb 28, 2022

View reviewed changes

catornow added 10 commits February 28, 2022 11:55

Removed backend arg

bf4f981

Aligned code with current main

cfcd629

Merge branch 'RestlessMixin' of github.com:catornow/qiskit-experiment…

c8ab58e

…s into RestlessMixin

Modified code and added override_processor arg

0aac8bd

Some docstring modifications

8c688ce

Added documentation

155657d

If esp readout is enabled it is set to False

b977083

Merge branch 'main' of github.com:Qiskit/qiskit-experiments into Rest…

747e445

…lessMixin

Lint error

41fb63f

Small modifications

cf15779

eggerdj mentioned this pull request Mar 2, 2022

Add BaseExperiment._finalize method #701

Merged

eggerdj suggested changes Mar 2, 2022

View reviewed changes

catornow and others added 9 commits March 2, 2022 21:20

Update qiskit_experiments/framework/restless_experiment.py

4a665a8

Co-authored-by: Daniel J. Egger <38065505+eggerdj@users.noreply.github.com>

Update qiskit_experiments/framework/restless_experiment.py

2f06ff5

Co-authored-by: Daniel J. Egger <38065505+eggerdj@users.noreply.github.com>

Update qiskit_experiments/framework/restless_experiment.py

db4bcb8

Co-authored-by: Daniel J. Egger <38065505+eggerdj@users.noreply.github.com>

Update qiskit_experiments/framework/restless_experiment.py

4ab4f4e

Co-authored-by: Daniel J. Egger <38065505+eggerdj@users.noreply.github.com>

Update qiskit_experiments/framework/restless_experiment.py

3bfc2c4

Co-authored-by: Daniel J. Egger <38065505+eggerdj@users.noreply.github.com>

Update qiskit_experiments/framework/restless_experiment.py

acd51ad

Co-authored-by: Daniel J. Egger <38065505+eggerdj@users.noreply.github.com>

Update qiskit_experiments/test/mock_iq_backend.py

a011453

Co-authored-by: Daniel J. Egger <38065505+eggerdj@users.noreply.github.com>

Black

19a544c

Corrected mistake

545b644

Fixed docs error

5067925

eggerdj reviewed Mar 7, 2022

View reviewed changes

eggerdj requested a review from nkanazawa1989 March 7, 2022 09:54

catornow and others added 6 commits March 7, 2022 11:01

Update qiskit_experiments/framework/restless_mixin.py

79991cc

Co-authored-by: Daniel J. Egger <38065505+eggerdj@users.noreply.github.com>

Update qiskit_experiments/library/characterization/fine_amplitude.py

077e21e

Co-authored-by: Daniel J. Egger <38065505+eggerdj@users.noreply.github.com>

Update test/data_processing/test_restless_experiment.py

a15d451

Co-authored-by: Daniel J. Egger <38065505+eggerdj@users.noreply.github.com>

Update test/data_processing/test_restless_experiment.py

3427aa3

Co-authored-by: Daniel J. Egger <38065505+eggerdj@users.noreply.github.com>

Implemented Daniel's suggestions

9d3da96

Black

0a4d4a2

eggerdj changed the title ~~[WIP] Restless Experiments~~ Restless Experiments Mar 7, 2022

eggerdj reviewed Mar 7, 2022

View reviewed changes

nkanazawa1989 requested changes Mar 7, 2022

View reviewed changes

Optional rep_delay

b6784ec

eggerdj mentioned this pull request Mar 8, 2022

Remove job metadata from BaseExperiment #719

Merged

catornow added 4 commits March 8, 2022 12:51

Added mixin documentation

d9a27cf

Changed override_restless_processor to `override_processor_by_restl…

9904d96

…ess` and modified default value

Implemented Naoki's suggestions

e229c26

DataProcessorError is raised if the data_processor analysis options d…

709bec8

…oes not exist

eggerdj approved these changes Mar 9, 2022

View reviewed changes

qiskit_experiments/framework/restless_mixin.py Show resolved Hide resolved

qiskit_experiments/framework/restless_mixin.py Show resolved Hide resolved

eggerdj and others added 3 commits March 9, 2022 16:49

Update qiskit_experiments/framework/restless_mixin.py

85d97a6

Merge branch 'main' into RestlessMixin

3189b73

Black

7799cc4

nkanazawa1989 approved these changes Mar 10, 2022

View reviewed changes

eggerdj merged commit e127031 into qiskit-community:main Mar 14, 2022

catornow mentioned this pull request Mar 14, 2022

Add RestlessMixin to further experiments #735

Merged

chriseclectic added the Changelog: New Feature Include in the "Added" section of the changelog label Apr 25, 2022

catornow mentioned this pull request May 2, 2022

New experiment run options can be set in .run method after calling .enable_restless #795

Open

Restless Experiments #689

Restless Experiments #689

Uh oh!

Conversation

catornow commented Feb 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Details and comments

Uh oh!

eggerdj left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eggerdj left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eggerdj left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eggerdj left a comment

Choose a reason for hiding this comment

Uh oh!

nkanazawa1989 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eggerdj left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nkanazawa1989 left a comment

Choose a reason for hiding this comment

Uh oh!

eggerdj commented Mar 11, 2022

Uh oh!

nkanazawa1989 commented Mar 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

catornow commented Feb 25, 2022 •

edited

Loading

nkanazawa1989 commented Mar 14, 2022 •

edited

Loading