Skip to content

Fix float serialization #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 20, 2022
Merged

Fix float serialization #770

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e986b9f
fixes bug
coruscating Apr 15, 2022
d74cae2
updated testt
coruscating Apr 15, 2022
79a9aed
Merge branch 'main' into fix-float-serialization
chriseclectic Apr 19, 2022
d49f2d1
Merge branch 'main' into fix-float-serialization
chriseclectic Apr 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions qiskit_experiments/framework/json.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,8 +466,8 @@ def default(self, obj: Any) -> Any: # pylint: disable=arguments-differ
# during serialization. Then both can be serialized as Variable.
# Note that UFloat doesn't have a tag.
settings = {
"value": obj.nominal_value,
"std_dev": obj.std_dev,
"value": _serialize_safe_float(obj.nominal_value),
"std_dev": _serialize_safe_float(obj.std_dev),
"tag": getattr(obj, "tag", None),
}
cls = uncertainties.core.Variable
Expand Down
21 changes: 21 additions & 0 deletions test/database_service/test_db_analysis_result.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

import math
import numpy as np
import uncertainties


from qiskit_experiments.database_service import DbAnalysisResultV1 as DbAnalysisResult
Expand Down Expand Up @@ -135,6 +136,26 @@ def test_display_format_inf(self):
self.assertEqual(DbAnalysisResult._display_format(math.inf), "Infinity")
self.assertEqual(DbAnalysisResult._display_format(-math.inf), "-Infinity")
self.assertEqual(DbAnalysisResult._display_format(math.nan), "NaN")
self.assertEqual(
DbAnalysisResult._display_format(
uncertainties.ufloat(math.nan, math.nan).nominal_value
),
"NaN",
)
self.assertEqual(
DbAnalysisResult._display_format(uncertainties.ufloat(math.nan, math.nan).std_dev),
"NaN",
)
self.assertEqual(
DbAnalysisResult._display_format(
uncertainties.ufloat(math.inf, -math.inf).nominal_value
),
"Infinity",
)
self.assertEqual(
DbAnalysisResult._display_format(uncertainties.ufloat(math.inf, -math.inf).std_dev),
"-Infinity",
)

def test_display_format_complex(self):
"""Test conversion of db displays"""
Expand Down