Calibrations libraries #778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wshanks
requested changes
Apr 21, 2022
Collaborator
wshanks
left a comment
wshanks
left a comment
There was a problem hiding this comment.
This looks good to me, but there are additional uses of library that need to be updated in the armonk tutorial and some of the other tests.
eggerdj
commented
Apr 22, 2022
Co-authored-by: Will Shanks <wshaos@posteo.net>
wshanks
approved these changes
Apr 25, 2022
chriseclectic
added
the
Changelog: API Change
paco-ri
pushed a commit
to paco-ri/qiskit-experiments
that referenced
this pull request
Jul 11, 2022
* This PR deprecates the library argument in favor of the libraries argument in the Calibrations class. Co-authored-by: Will Shanks <wshaos@posteo.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The library argument to the calibrations has been deprecated in favor of the libraries argument.
Ideally, we should get this in for 0.3 to avoid keeping library until release 0.5.
Details and comments
See code.