Skip to content

Update native iOS dependency version #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Maria-Bordunova merged 5 commits into from
Feb 21, 2022
Merged

Update native iOS dependency version #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e432360
Update native iOS dependency version
Maria-Bordunova Feb 16, 2022
bce0c63
Fix for Android v2 embedding (sample app)
Maria-Bordunova Feb 16, 2022
b4565a3
Update native iOS dependency to 2.18.3
Maria-Bordunova Feb 17, 2022
1a8c083
Apply suggestions from code review
Maria-Bordunova Feb 21, 2022
8d28d19
Merge branch 'develop' into update_native_iOS
Maria-Bordunova Feb 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion example/android/app/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
<uses-permission android:name="android.permission.ACCESS_WIFI_STATE"/>
<uses-permission android:name="com.android.vending.BILLING"/>
<application
android:name="io.flutter.app.FlutterApplication"
android:label="com.qonversion.sample"
android:icon="@mipmap/ic_launcher">
<activity
Expand Down
2 changes: 1 addition & 1 deletion ios/qonversion_flutter.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Pod::Spec.new do |s|
s.source_files = 'Classes/**/*'
s.dependency 'Flutter'
s.platform = :ios, '9.0'
s.dependency 'Qonversion', '2.18.1'
s.dependency 'Qonversion', '2.18.3'

# Flutter.framework does not contain a i386 slice. Only x86_64 simulators are supported.
s.pod_target_xcconfig = { 'DEFINES_MODULE' => 'YES', 'VALID_ARCHS[sdk=iphonesimulator*]' => 'x86_64' }
Expand Down
9 changes: 5 additions & 4 deletions lib/src/qonversion.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,11 +298,12 @@ class Qonversion {

/// Enable attribution collection from Apple Search Ads. NO by default.
static Future<void> setAppleSearchAdsAttributionEnabled(bool enable) async {
if (Platform.isIOS) {
return _channel.invokeMethod(
Constants.mSetAppleSearchAdsAttributionEnabled,
{Constants.kEnableAppleSearchAdsAttribution: enable});
if (!Platform.isIOS) {
return null;
}

return _channel.invokeMethod(Constants.mSetAppleSearchAdsAttributionEnabled,
{Constants.kEnableAppleSearchAdsAttribution: enable});
}

/// Set push token to Qonversion to enable Qonversion push notifications
Expand Down
2 changes: 1 addition & 1 deletion macos/qonversion_flutter.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Pod::Spec.new do |s|
s.source_files = 'Classes/**/*'
s.dependency 'FlutterMacOS'
s.platform = :osx, '10.12'
s.dependency 'Qonversion', '2.18.1'
s.dependency 'Qonversion', '2.18.3'
s.pod_target_xcconfig = { 'DEFINES_MODULE' => 'YES' }
s.swift_version = '5.0'
s.static_framework = true
Expand Down